Skip to content

Commit

Permalink
sagemathgh-36345: ecm: Work around build failure with Xcode 15
Browse files Browse the repository at this point in the history
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->
Part of the fix for:
- sagemath#36342

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->

URL: sagemath#36345
Reported by: Matthias Köppe
Reviewer(s):
  • Loading branch information
Release Manager committed Sep 27, 2023
2 parents 2c71472 + c22131f commit b018563
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 4 deletions.
6 changes: 3 additions & 3 deletions build/pkgs/configure/checksums.ini
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
tarball=configure-VERSION.tar.gz
sha1=6652d527e5319a54a9ab4e4c2faa48f13afb967d
md5=156c1701927f83baf70db3f53314bcbe
cksum=3874404163
sha1=c6efbc310523cfc3c1f2fa3f86a0761311de6003
md5=670d28340bbdd4cabaeb3e76a2004dbe
cksum=2059970385
2 changes: 1 addition & 1 deletion build/pkgs/configure/package-version.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
930d65e684b584c6ca664821f008ac205880d857
8cf728dfa04520d04e7eac3f8e6751eab0c3dde5
6 changes: 6 additions & 0 deletions build/pkgs/ecm/spkg-install.in
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,12 @@ export CFLAGS # Not exported by 'sage-env'. LDFLAGS are exported above if
# necessary. We currently don't set (or modify) any other
# environment variables, so don't have to export them here.

# Workaround for build failure with Xcode 15, https://github.com/sagemath/sage/issues/36342
case "$UNAME" in
Darwin*)
export gmp_cv_asm_underscore=yes
;;
esac

###############################################################################
# Now configure ECM:
Expand Down

0 comments on commit b018563

Please sign in to comment.