Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when different file than rewired gets loaded #149

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

brokentone
Copy link

I believe many of the issues with TypeError with const are related to the loose (imperative) relationship between rewire and the require loaders as detailed here: #147

These issues are possibly related:
#137
#144

This does not fix that, but makes the issue more explicit.

This specific change is looking to turn the js and coffee loaders into closures which allow us to have the context to ensure that the loaded file is the same one which has been rewired.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.6%) to 96.97% when pulling a7b7c38 on brokentone:bugfix/error-if-requiring-wrong-file into c059ffc on jhnns:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants