Fixed Sonar Bugs and some Criticals

[nomuna]

• removed tests from coverage, and analysis
• removed dtos and domain classes from redundancy check
  since sonar reports common fields in entities/dtos as redundancy
• made sonar ignore some useful comments using // NOSONAR marking
• removed commented out codes
• removed / refactored cases of logging and throwing exceptions
• TODO comment wrapped in multiline/javadoc comment so that
  sonar does not see it as commented out code
• Refactored some fields and their getters and setters to
  conform Java Language Conventions
• replaced switch with map lookup and lambda call to reduce
  the cyclomatic complexity of alert-error.component.ts

Fix #209
Fix #312

[nomuna]

Sorry @SudharakaP ,

I removed the remote branch on my fork after rebasing to include changes from upstream... It was a mistake.

I hope you were not working on it at the time.

[mraible]

@SudharakaP can this be merged?

[nomuna]

Hi @mraible,

I updated my fork. Tests are still running on windows.

mvn sonar:sonar

is running out of the box on my Windows 10 machine with Java 17.0.2.

sonar-scanner (installed globally with npm) used to work out of the box too, but apparently the new version does some additional checks and fails if you do not specify the path to the java binaries.

I had to do the following change locally in the file sonar-project.properties.

sonar.sources=src/main/
sonar.java.binaries=./target/classes  #<-- this is new
sonar.host.url=http://localhost:9001

sonar-scanner also will not find the test result for the client and fail.

So for sonar-scanner I had to

• make the change above in sonar-project.properties
• run the client tests with

npm test

and then run sonar-scanner at the end.

Used the image sonarqube:8.8-community to test.

[deepu105]

@jdubois @DanielFran this looks like some good improvements, WDYT?

[jdubois]

Yes, this looks good, thanks @nomuna ! I'm going to merge this for today's release.