Improve Test Coverage - JHipsterService

[Strat1987]

Related to #213

[CLAassistant]

All committers have signed the CLA.

[SudharakaP]

@Strat1987 : Please sign the CLA. If you have any issues signing it let us know. 😄

[SudharakaP]

@Strat1987 : Same thing happening here as mentioned by pascal; #247 (comment)

[roexber]

@SudharakaP signed with the corresponding username now

[SudharakaP]

@SudharakaP signed with the corresponding username now

@Strat1987 : Thanks it looks good; can you re-base and run prettier on the files; npm run prettier:format so that the formatting is done properly. 😄

EDIT: You don't have to run prettier as it's auto run on commit anyways. My mistake. 😢

[roexber]

@SudharakaP I did run prettier myself but it seems to differ from what's on master

[SudharakaP]

@SudharakaP I did run prettier myself but it seems to differ from what's on master

@Strat1987 : Hmm.... I am not sure why it changes when you run prettier. Did you run it through npm run prettier:format or did it run automatically when you committed? But on another note, there's a compilation error since it seems that you've used the runProcess method in the tests but I think it's private. Could you please correct that? 😄

[SudharakaP]

@Strat1987 : Its some minor changes, so I can do it too if you could give me the permission to modify the PR.

[roexber]

all should be well this time around

[SudharakaP]

all should be well this time around

@roexber : Thanks a lot for the contribution; it's really helpful and makes our test suite much better. 😄

[roexber]

Thank you, I'll try my best to squeeze in some more.

[SudharakaP]

You are welcome. 🙃

…

On Sun, Oct 18, 2020, 11:47 PM roexber ***@***.***> wrote: Thank you, I'll try my best to squeeze in some more. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#248 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC64D7NWTQWGANVSX7YALSDSLPOHVANCNFSM4SPNFGFQ> .