Merge pull request #426 from jhipster/codesmells

Sonar: Update this function so that its implementation is not identical to the one on line 69
jhipster · Sep 24, 2023 · 35cf219 · 35cf219
2 parents c094722 + 605f9fb
commit 35cf219
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/src/main/webapp/app/home/jdl-metadata/jdl-studio.component.ts b/src/main/webapp/app/home/jdl-metadata/jdl-studio.component.ts
@@ -67,9 +67,7 @@ export class DeleteJdlStudioComponent implements OnInit, OnDestroy {
  }
 
  ngOnDestroy(): void {
- if (this.subscription) {
- this.subscription.unsubscribe();
- }
+ unsubscribe(this.subscription);
  }
 }
 
@@ -164,12 +162,16 @@ export class ApplyJdlStudioComponent implements OnInit, OnDestroy {
  }
 
  ngOnDestroy(): void {
- if (this.subscription) {
- this.subscription.unsubscribe();
- }
+ unsubscribe(this.subscription);
  }
 
  isAtLeastOneGitProviderAvailableAndConfigured(): boolean {
  return (this.gitConfig.githubAvailable && this.githubConfigured) || (this.gitConfig.gitlabAvailable && this.gitlabConfigured) || false;
  }
 }
+
+const unsubscribe = (subscription: Subscription | undefined) => {
+ if (subscription) {
+ subscription.unsubscribe();
+ }
+};