Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve faker 9 breaking changes #27368

Merged
merged 7 commits into from
Oct 2, 2024
Merged

resolve faker 9 breaking changes #27368

merged 7 commits into from
Oct 2, 2024

Conversation

mshima
Copy link
Member

@mshima mshima commented Sep 23, 2024

  • faker.faker was replaced with incompatible faker.helpers.fake
  • refDate throws exception on invalid dates.

fixes:

  • use typescript to avoid obvious errors
  • add changelogDate validation.
  • add generateFromPattern that uses helpers.fromRegEx and fall back to RandExp.
  • add valid changelogDate to built-in entities.
  • fix changelogDate in IT samples fix wrong values due to liquibase changelog backward compatibility

Fixes #27367


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@mshima mshima marked this pull request as ready for review October 2, 2024 18:07
@DanielFran DanielFran merged commit 547c270 into jhipster:main Oct 2, 2024
55 checks passed
@mshima mshima deleted the faker branch October 2, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Faker 9 breaking changes are not resolved.
2 participants