-
-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Guzzle request options configurable #655
Conversation
0f29e47
to
3f21a05
Compare
We have now the proof, see the test failures |
this should probably say *with self-signed certificate in the title, because that's the only issue here afaik, would need a setting to allow those I guess. Also has nothing to with this project, if not already supported it's something that the driver needs to support? I know some chrome drivers have this |
@Berdir, now we're using EDIT: Relevant code: |
Yes, maybe we should do the Guzzle request options configurable |
5f60912
to
666de06
Compare
666de06
to
30e3369
Compare
Ready for review |
This looks great. Thanks! |
Problem
Behat tests are failing for logged in users when the site is accessed via HTTPS and SSL peer verification is failing. But with
BrowserTestBase
we're able to run such tests. Testing should not require a valid SSL certificateProposal
Make Guzzle request options configurable
Example:
In this example,
browserkit_http.guzzle_request_options
is configured to instantiate the Guzzle underlying HTTP client with theverify
request option set tofalse
, same asBrowserTestBase:: initMink()
is doing