added login pages, and register/login functionality #15
Conversation
jhcoll
force-pushed
the
feature_login_page
branch
from
60b0be1 to
fca2e11
Compare
| const [showError, setShowError] = useState(false); | ||
| const [errorText, setErrorText] = useState(""); | ||
| const [idToken, setIdToken] = useState(); | ||
| const [userIdToken, setUserIdToken] = useState(); |
There was a problem hiding this comment.
What's the difference between userIdToken and idToken?
| const navigate = useNavigate(); | ||
| const emailRef = useRef(); | ||
| const passRef = useRef(); | ||
| let fireResp = false; |
There was a problem hiding this comment.
This is probably fine but it isn't a very reacty thing to do. A quick improvement would be to move it inside the function createAccount(account) because there at least the side effects are managed. In general though with good react there should be no side-effects inside a component which means that all variables should be consts at the top level or hooks if state is required. The better option might be to attempt to embed the boolean inside the data of the .then though this might not necessarily be possible
| <div className={classes.content}> | ||
| <div className={classes.input}> | ||
| <input required placeholder="Email" ref={emailRef}></input> | ||
| <input required placeholder="Password" ref={passRef}></input> |
There was a problem hiding this comment.
Might be nice if the password is hidden behind *s or dots when displayed, might be manageable using hooks and states or a configure option
No description provided.