-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Devel/extend #1
Devel/extend #1
Conversation
I was able to run it on both DataArray and Dataset, create a series of tests for multiple grids and find a draft way to deal with masks. Pressure levels seems supported by default. |
I had a bit of fights with the different versions, but tests are now in place from 3.7 to 3.10. Environment creation is now safe. |
…ressure levels, to be investigated
Last commit introduced a few fixes to work with Datasets, especially with masks and |
Hi, what is the "remove dobule mask computation" commit? Did you find a way to avoid computing the mask itself or was it duplicated? |
Ahaha no I did it twice :-) |
Last commit includes a new treatment of the masks - computed once when the weights are loaded and initialised - and significantly reduces the overhead when working with xarray.Dataset() to about 10%. Speedup figures are discussed in #2, and mostly suggest that with a full loading of the files the speed up compared to CDO is about ~1.5-3x. Slower performance are achieved for very big files. However, the good news is that with the current configuration it seems that writing to the disk is not a bottleneck, so that we are faster than CDO also in this case. I will consider this as done and ask for review from @jhardenberg |
Last commit introduces a very small fix which allows for automatically transferring attributes from the original dataset to the regridded one. |
Proceeding to the merge! |
This branch addresses a few issues of smmregrid so far