Dismiss on Escape #88
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@glatzert, also jetzt fangen wir das Event direkt ab, anstatt mit Tasteneingaben zu arbeiten |
glatzert
requested changes
Mar 28, 2024
…log, also removed libman.json
|
@glatzert so wir benutzen jetzt die onAfterRender und entfernen den EventListener auch wieder am Ende. Wie die libman.json entstanden ist, das ist mir noch ein Rätsel. |
Jemand hat sich verklickt (Manage Client-Side dependencies) und hat dann beim Commit nicht aufgepasst, was gestaged ist ;) |
glatzert
reviewed
Apr 4, 2024
| @@ -119,10 +128,12 @@ | |||
|
|
|||
| public void Close(ModalResult result) | |||
| { | |||
| _ = _jsModule!.InvokeVoidAsync("CloseDialog", _componentId); | |||
| if (_taskCompletionSource.Task.IsCompleted) return; | |||
glatzert
reviewed
Apr 4, 2024
| var dialog = document.getElementById(guid); | ||
| dialog.removeEventListener("close", () => { reference.invokeMethodAsync("Close"); }); |
There was a problem hiding this comment.
Seid ihr sicher, dass das die Methode unten aus dem eventListener entfernt?
glatzert
reviewed
May 23, 2024
| } | ||
| } | ||
|
|
||
| const testClass = new closeListener(); |
There was a problem hiding this comment.
Ich denke, Testcode sollte schon gar nicht in einem Commit sein, aber spätestens im PR sollte es nicht auftauchen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pressing escape now dismisses the modal