hal: Tock: Namespace HAL, update timer implementation and update libtock-c #1313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Tock CI failure is because there is a chicken and egg problem with the libtock-c submodule. We need tock/libtock-c#456 merged and then update libtock-c based on these changes. |
Tock has direct support for querying time. The prior `millis()` method here replicated the same functionality, but missed some corner case concerns around overflow/wrapping. Instead, just use the native Tock time getter method. This also removes unneeded global variables and methods.
Update to the latest libtock-c commit. libtock-c now includes a libtockHal.h, so we can use that instead of the version here. Signed-off-by: Alistair Francis <[email protected]>
alistair23
force-pushed
the
pats/tock-hal-updates
branch
from
075d977
to
ff12e94
Compare
alistair23
changed the title
alistair23
changed the title
|
Looks good to me! @alistair23 since the PR in libtock was merged, I guess that now this is ready to be merged as well, correct? |
Yep! This is ready to go |
|
Merged, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on the discussion here: tock/libtock-c#456 (comment)
This namespaces the Tock HAL public macro and structs and uses the native timer implementation.
This also updates to the latest libtock-c commit. libtock-c now includes a libtockHal.h, so we can use that instead of the version in RadioLib.