Use glog to replace revel's logging system. Be compatible with newest re... #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This diff seems excessive did you 'go fmt' the code before committing? |
|
Yes, I go fmt it. |
|
That's strange. I'm running go 1.1.1 and my go fmt produces a different layout than yours. Can you confirm your go version? Also is this for revel's v1 branch? |
|
my go version is 1.1.2. Yes, that is for revel's v1 branch. 2013/9/25 Jeff Graham [email protected]
|
|
Sorry I've left this lingering. I just pushed a v1 branch would you mind re-rolling against that branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...vel.