Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added gridshib-common and gridshib-saml-tools. #113

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

ysvenkat
Copy link

Documentation will follow in a subsequent commit/pull-request.

@bbockelm
Copy link
Contributor

Hi,

This seems to be a self-contained project, no? Is there any reason this can't live as its separate github project?

Brian

@ysvenkat
Copy link
Author

This has a dependency on a couple of Jglobus modules and there weren't
going to be any releases of gridshib-saml-tools as a separate project.
Hence, Suresh and Jim (cc'd) felt it would be best to bring it into the
Jglobus fold for automatic releases with other Jglobus modules and
community maintenance...

On 9/16/13 3:32 PM, "Brian Bockelman" [email protected] wrote:

Hi,
This seems to be a self-contained project, no? Is there any reason this
can't live as its separate github project?
Brian

Reply to this email directly or
view it on GitHub
#113 (comment).

@smarru
Copy link
Member

smarru commented Sep 16, 2013

I echo Venkat's comment. These tools were long associated with Globus tools like the http://gridshib.globus.org/docs/gridshib-saml-tools-0.5.0/readme.html and GRAM Audit records. For instance to submit a GRAM job and feed in the required audit fields (http://www.globus.org/toolkit/docs/5.2/5.2.4/gram5/admin/#idp6576736), the JGlobus client feeds in by decorating the proxy with saml assertions.

However, I can see the concerns of the big PR. Briefly skimming through I see that it should not disrupt or break the core jglobus functionality. Unless there are objections, I can volunteer to merge it and test it through and work with feedback to @ysvenkat .

@ellert
Copy link
Contributor

ellert commented Nov 5, 2013

This pull request adds pre-compiled jars. For me this is a reason to reject it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants