Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request exceptions catched to prevent entering in a broken connection state #95

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ghost
Copy link

@ghost ghost commented Jul 19, 2019

Sometimes, when you make a request, it can raise httplib Exceptions like BadStatusLine.
When this happens, the line to get the response is not called, and connection enter in a broken state.

If you make successive JSON calls, the object will always return "httplib.CannotSendRequest" error.

So, the connection is closed after the exception raised to prevent this kind of behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants