Handle filter expression literals without a comparison expression

jg-rp · May 20, 2024 · d4cb1a6 · d4cb1a6
1 parent af06a81
commit d4cb1a6
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 1 deletion.
diff --git a/src/path/parse.ts b/src/path/parse.ts
@@ -3,6 +3,7 @@ import { JSONPathSyntaxError, JSONPathTypeError } from "./errors";
 import {
   BooleanLiteral,
   FilterExpression,
+  FilterExpressionLiteral,
   FunctionExtension,
   InfixExpression,
   LogicalExpression,
@@ -330,6 +331,14 @@ export class Parser {
         );
       }
     }
+
+    if (expr instanceof FilterExpressionLiteral) {
+      throw new JSONPathSyntaxError(
+        "filter expression literals must be compared",
+        expr.token,
+      );
+    }
+
     return keys
       ? new KeysFilterSelector(
           this.environment,
@@ -387,7 +396,21 @@ export class Parser {
     if (COMPARISON_OPERATORS.has(operator)) {
       this.throwForNonComparable(left);
       this.throwForNonComparable(right);
+    } else {
+      if (left instanceof FilterExpressionLiteral) {
+        throw new JSONPathSyntaxError(
+          "filter expression literals must be compared",
+          left.token,
+        );
+      }
+      if (right instanceof FilterExpressionLiteral) {
+        throw new JSONPathSyntaxError(
+          "filter expression literals must be compared",
+          right.token,
+        );
+      }
     }
+
     return new InfixExpression(tok, left, operator, right);
   }
 

diff --git a/tests/path/cts b/tests/path/cts