Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic in Analyzer Manager execution #952

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Sep 13, 2023

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Fix the following issue:

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0xc0a696]
goroutine 1 [running]:
os.(*ProcessState).exited(...)
/usr/local/go/src/os/exec_posix.go:83
os.(*ProcessState).Exited(...)
/usr/local/go/src/os/exec.go:155
github.com/jfrog/jfrog-cli-core/v2/xray/utils.(*AnalyzerManager).Exec.func1()
/home/frogger/go/pkg/mod/github.com/jfrog/jfrog-cli-core/[email protected]/xray/utils/analyzermanager.go:105 +0x36
github.com/jfrog/jfrog-cli-core/v2/xray/utils.(*AnalyzerManager).Exec(0xc0000aeda0, {0xc0005f8600, 0x36}, {0x110cfbd, 0x2}, 0xc0005d5400?)
/home/frogger/go/pkg/mod/github.com/jfrog/jfrog-cli-core/[email protected]/xray/utils/analyzermanager.go:113 +0x1a9
github.com/jfrog/jfrog-cli-core/v2/xray/audit/jas.(*ApplicabilityScanManager).runAnalyzerManager(...)
/home/frogger/go/pkg/mod/github.com/jfrog/jfrog-cli-core/[email protected]/xray/audit/jas/applicabilitymanager.go:159

@yahavi yahavi requested a review from sverdlov93 September 13, 2023 07:58
@yahavi yahavi added the bug Something isn't working label Sep 13, 2023
@yahavi yahavi marked this pull request as ready for review September 13, 2023 08:10
@yahavi yahavi self-assigned this Sep 13, 2023
@yahavi yahavi merged commit cdb4f7c into jfrog:dev Sep 13, 2023
1 check failed
@yahavi yahavi deleted the panic-in-analyzer branch September 13, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants