Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start Progress Bar with 1 Filler (🟦) to avoid initial empty display #1263

Merged
merged 32 commits into from
Sep 15, 2024

Conversation

sverdlov93
Copy link
Contributor

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

PR Headline: "Progress Bar Now Starts with 1 Filler for Immediate Visual Feedback"

PR Description: This PR ensures that the progress bar starts with 1 filler, providing immediate visual feedback. Instead of appearing empty for a prolonged time, particularly when there are many tasks (e.g., 100k tasks) but only a few bars (e.g., 10 bars), the bar will now display a single filled block at the start.

For example:

Initial state: [🟦 ]
As progress continues: [🟦🟦 ], and so on.
This improves the visual experience, especially during long-running processes.

sverdlov93 and others added 28 commits August 25, 2024 11:59
Signed-off-by: Michael Sverdlov <[email protected]>
Signed-off-by: Michael Sverdlov <[email protected]>
Signed-off-by: Michael Sverdlov <[email protected]>
Signed-off-by: Michael Sverdlov <[email protected]>
Signed-off-by: Michael Sverdlov <[email protected]>
Signed-off-by: Michael Sverdlov <[email protected]>
Signed-off-by: Michael Sverdlov <[email protected]>
Signed-off-by: Michael Sverdlov <[email protected]>
Signed-off-by: Michael Sverdlov <[email protected]>
Signed-off-by: Michael Sverdlov <[email protected]>
Signed-off-by: Michael Sverdlov <[email protected]>
Signed-off-by: Michael Sverdlov <[email protected]>
Signed-off-by: Michael Sverdlov <[email protected]>
Signed-off-by: Michael Sverdlov <[email protected]>
Signed-off-by: Michael Sverdlov <[email protected]>
…x-template

# Conflicts:
#	go.mod
#	go.sum
Signed-off-by: Michael Sverdlov <[email protected]>
Signed-off-by: Michael Sverdlov <[email protected]>
Signed-off-by: Michael Sverdlov <[email protected]>
Signed-off-by: Michael Sverdlov <[email protected]>
@sverdlov93 sverdlov93 requested a review from yahavi September 12, 2024 14:16
Signed-off-by: Michael Sverdlov <[email protected]>
Signed-off-by: Michael Sverdlov <[email protected]>
Signed-off-by: Michael Sverdlov <[email protected]>
@eyalbe4 eyalbe4 added the improvement Automatically generated release notes label Sep 14, 2024
Signed-off-by: Michael Sverdlov <[email protected]>
@sverdlov93 sverdlov93 changed the title Start Progress Bar with 1 Filler (🟦) to Avoid Initial Empty Display Start Progress Bar with 1 Filler (🟦) to avoid initial empty display Sep 15, 2024
@sverdlov93 sverdlov93 merged commit 47e4ce9 into jfrog:dev Sep 15, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants