Update Summaries extended page link & Add logs (#1256)

jfrog · Sep 4, 2024 · ebf2092 · ebf2092
1 parent 3293aac
commit ebf2092
Show file tree

Hide file tree

Showing 8 changed files with 10 additions and 7 deletions.
diff --git a/artifactory/utils/commandsummary/buildinfosummary.go b/artifactory/utils/commandsummary/buildinfosummary.go
@@ -5,6 +5,7 @@ import (
 	buildInfo "github.com/jfrog/build-info-go/entities"
 	"github.com/jfrog/jfrog-cli-core/v2/artifactory/utils"
 	"github.com/jfrog/jfrog-cli-core/v2/artifactory/utils/container"
+	"github.com/jfrog/jfrog-client-go/utils/log"
 	"path"
 	"strings"
 )
@@ -273,9 +274,11 @@ func fitInsideMarkdownTable(str string) string {
 }
 
 func getScanResults(scannedEntity string) (sc ScanResult) {
+	log.Debug("Getting scan results for: ", scannedEntity)
 	if sc = StaticMarkdownConfig.scanResultsMapping[fileNameToSha1(scannedEntity)]; sc != nil {
 		return sc
 	}
+	log.Debug("No scan results found for: ", scannedEntity)
 	return StaticMarkdownConfig.scanResultsMapping[NonScannedResult]
 }
 

diff --git a/artifactory/utils/commandsummary/commandsummary.go b/artifactory/utils/commandsummary/commandsummary.go
@@ -127,7 +127,7 @@ func (cs *CommandSummary) Record(data any) (err error) {
 // SummaryIndex: The name of the index under which the data will be stored.
 // Args: Additional arguments used to determine the file name.
 func (cs *CommandSummary) RecordWithIndex(data any, summaryIndex Index, args ...string) (err error) {
-	log.Debug("Recording data with index:", summaryIndex)
+	log.Debug("Recording data with index:", summaryIndex, "and args:", args)
 	return cs.recordInternal(data, summaryIndex, args)
 }
 

diff --git a/artifactory/utils/commandsummary/markdownConfig.go b/artifactory/utils/commandsummary/markdownConfig.go
@@ -24,7 +24,7 @@ type MarkdownConfig struct {
 	scanResultsMapping map[string]ScanResult
 }
 
-const extendedSummaryLandPage = "https://jfrog.com/help/r/jfrog-and-github-integration-guide/jfrog-and-github-integration-features-matrix"
+const extendedSummaryLandPage = "https://jfrog.com/help/access?xinfo:appid=csh-gen-gitbook"
 
 var StaticMarkdownConfig = MarkdownConfig{}
 

diff --git a/artifactory/utils/testdata/command_summaries/basic/build-info-table.md b/artifactory/utils/testdata/command_summaries/basic/build-info-table.md
@@ -2,6 +2,6 @@
 
 | Build Info | Security Violations | Security Issues |
 | :--------- | :------------ | :------------ |
-| <a href="https://jfrog.com/help/r/jfrog-and-github-integration-guide/jfrog-and-github-integration-features-matrix">🐸 Enable the linkage to Artifactory</a><br><br> buildName 123 | Not scanned | Not scanned |
+| <a href="https://jfrog.com/help/access?xinfo:appid=csh-gen-gitbook">🐸 Enable the linkage to Artifactory</a><br><br> buildName 123 | Not scanned | Not scanned |
 
 
diff --git a/artifactory/utils/testdata/command_summaries/basic/docker-image-module.md b/artifactory/utils/testdata/command_summaries/basic/docker-image-module.md
@@ -10,4 +10,4 @@
 
 | Artifacts | Security Violations | Security Issues |
 | :------------ | :--------------------- | :------------------ |
-| <a href="https://jfrog.com/help/r/jfrog-and-github-integration-guide/jfrog-and-github-integration-features-matrix">🐸 Enable the linkage to Artifactory</a><br><br><pre>📦 docker-local<br>└── 📁 image2<br>    └── 📁 sha256:552c<br>        └── 📄 sha256__aae9<br><br></pre> | Not scanned | Not scanned |
+| <a href="https://jfrog.com/help/access?xinfo:appid=csh-gen-gitbook">🐸 Enable the linkage to Artifactory</a><br><br><pre>📦 docker-local<br>└── 📁 image2<br>    └── 📁 sha256:552c<br>        └── 📄 sha256__aae9<br><br></pre> | Not scanned | Not scanned |
diff --git a/artifactory/utils/testdata/command_summaries/basic/generic-module.md b/artifactory/utils/testdata/command_summaries/basic/generic-module.md
@@ -10,4 +10,4 @@
 
 | Artifacts | Security Violations | Security Issues |
 | :------------ | :--------------------- | :------------------ |
-| <a href="https://jfrog.com/help/r/jfrog-and-github-integration-guide/jfrog-and-github-integration-features-matrix">🐸 Enable the linkage to Artifactory</a><br><br><pre>📦 generic-local<br>└── 📁 path<br>    └── 📁 to<br>        └── 📄 artifact2<br><br></pre> | Not scanned | Not scanned |
+| <a href="https://jfrog.com/help/access?xinfo:appid=csh-gen-gitbook">🐸 Enable the linkage to Artifactory</a><br><br><pre>📦 generic-local<br>└── 📁 path<br>    └── 📁 to<br>        └── 📄 artifact2<br><br></pre> | Not scanned | Not scanned |
diff --git a/artifactory/utils/testdata/command_summaries/basic/maven-module.md b/artifactory/utils/testdata/command_summaries/basic/maven-module.md
@@ -10,4 +10,4 @@
 
 | Artifacts | Security Violations | Security Issues |
 | :------------ | :--------------------- | :------------------ |
-| <a href="https://jfrog.com/help/r/jfrog-and-github-integration-guide/jfrog-and-github-integration-features-matrix">🐸 Enable the linkage to Artifactory</a><br><br><pre>📦 libs-release<br>└── 📁 path<br>    └── 📁 to<br>        └── 📄 artifact1<br><br></pre> | Not scanned | Not scanned |
+| <a href="https://jfrog.com/help/access?xinfo:appid=csh-gen-gitbook">🐸 Enable the linkage to Artifactory</a><br><br><pre>📦 libs-release<br>└── 📁 path<br>    └── 📁 to<br>        └── 📄 artifact1<br><br></pre> | Not scanned | Not scanned |
diff --git a/artifactory/utils/testdata/command_summaries/basic/multiarch-docker-image.md b/artifactory/utils/testdata/command_summaries/basic/multiarch-docker-image.md
@@ -10,4 +10,4 @@
 
 | Artifacts | Security Violations | Security Issues |
 | :------------ | :--------------------- | :------------------ |
-| <a href="https://jfrog.com/help/r/jfrog-and-github-integration-guide/jfrog-and-github-integration-features-matrix">🐸 Enable the linkage to Artifactory</a><br><br><pre><details><summary>linux/amd64/multiarch-image:1</summary><br>📦 docker-local<br>└── 📁 multiarch-image<br>    ├── 📁 sha256:552c<br>    │   └── 📄 sha256<br>    └── 📄 sha256<br><br></details></pre> | Not scanned | Not scanned |
+| <a href="https://jfrog.com/help/access?xinfo:appid=csh-gen-gitbook">🐸 Enable the linkage to Artifactory</a><br><br><pre><details><summary>linux/amd64/multiarch-image:1</summary><br>📦 docker-local<br>└── 📁 multiarch-image<br>    ├── 📁 sha256:552c<br>    │   └── 📄 sha256<br>    └── 📄 sha256<br><br></details></pre> | Not scanned | Not scanned |