[jfrog-platform] Added podSecurityContext and containerSecurityContext for pre-upgrade-check migration hook container #1929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re-upgrade-check migration hook container
oumkale
reviewed
Oct 15, 2024
| @@ -103,6 +103,10 @@ rabbitmq: | |||
| image: | |||
| repository: bitnami/rabbitmq | |||
| tag: 3.12.10-debian-11-r1 | |||
| podSecurityContext: | |||
There was a problem hiding this comment.
It seems like these changes are specific to you; we are ignoring them
There was a problem hiding this comment.
I had to add this because otherwise 'helm lint' gives errors about unknown variables.
oumkale
reviewed
Oct 15, 2024
| @@ -242,6 +246,11 @@ artifactory: | |||
| url: '{{ include "database.url" . }}' | |||
| user: artifactory | |||
| password: artifactory | |||
| ingress: | |||
There was a problem hiding this comment.
It seems like these changes are specific to you; we are ignoring them
There was a problem hiding this comment.
I had to add this because otherwise 'helm lint' gives errors about unknown variables.
|
HI @mrarends, Thank you so much for your efforts 🥳🥳. We will review this internally and update you once the release is out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[artifactory])What this PR does / why we need it:
The new pre-upgrade-check pod and container is missing the option to set security context settings. On clusters that require more strict settings the pre-upgrade-check can not be started:
Special notes for your reviewer: