Skip to content

Commit

Permalink
Update to Alpine 3.11 on 2.7 python images. Add contribution section …
Browse files Browse the repository at this point in the history
…to README
  • Loading branch information
jfloff committed Mar 27, 2020
1 parent 553d3d3 commit 2cbadd9
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 4 deletions.
2 changes: 1 addition & 1 deletion 2.7-onbuild/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM alpine:3.8
FROM alpine:3.11

# VERSIONS
ENV ALPINE_VERSION=3.8 \
Expand Down
2 changes: 1 addition & 1 deletion 2.7-slim/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM alpine:3.8
FROM alpine:3.11

# VERSIONS
ENV ALPINE_VERSION=3.8 \
Expand Down
2 changes: 1 addition & 1 deletion 2.7/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM alpine:3.8
FROM alpine:3.11

# VERSIONS
ENV ALPINE_VERSION=3.8 \
Expand Down
4 changes: 3 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ A small Python Docker image based on [Alpine Linux](http://alpinelinux.org/).
- [Debugging](#debugging)
- [Additional Arguments](#additional-arguments)
- [Ecosystem](#ecosystem)
- [Contribution](#contribution)
- [License](#license)

<!-- /MDTOC -->
Expand Down Expand Up @@ -233,7 +234,8 @@ These are some of the images that use `jfloff/alpine-python` as base image. *If
[busmuth-hub]: https://hub.docker.com/r/eggdrasyl/bismuth-node/



## Contribution
Feel free to contribute with whatever you feel like this image is missing. There is also some changes that happen often like, updating Alpine or Python versions. Do not forget that this repo folders mirror **Python** version and **_not_** Alpine versions.

## License
The code in this repository, unless otherwise noted, is MIT licensed. See the `LICENSE` file in this repository.

3 comments on commit 2cbadd9

@biopsihoz
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice update. Now i would fork before use image =)
All builds return error after update
node_modules/grunt-sass/node_modules/node-sass: Command failed.

@jfloff
Copy link
Owner Author

@jfloff jfloff commented on 2cbadd9 Mar 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice update. Now i would fork before use image =)
All builds return error after update
node_modules/grunt-sass/node_modules/node-sass: Command failed.

Would you mind open an issue and the detail the problem? This is most likely due to the updated Alpine version. This probably indicates that we need tags with Alpine versions as well (e.g. 3.8-alpine3.10, 3.8-alpine3.11)

@biopsihoz
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#68

Please sign in to comment.