Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block on skipped matrix #111

Closed
wants to merge 20 commits into from
Closed

Block on skipped matrix #111

wants to merge 20 commits into from

Conversation

jflo
Copy link
Owner

@jflo jflo commented Mar 26, 2024

PR description

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Most advanced CI tests are deferred until PR approval, but you could:

  • locally run all unit tests via: ./gradlew build
  • locally run all acceptance tests via: ./gradlew acceptanceTest
  • locally run all integration tests via: ./gradlew integrationTest
  • locally run all reference tests via: ./gradlew ethereum:referenceTests:referenceTests

jflo and others added 17 commits March 26, 2024 11:05
@jflo
Artifactory publish (hyperledger#6781)
6542df0 
* correcting env vars
* removes conditionals which result in skipped tasks being considered success
* spotless fix

---------

Signed-off-by: Justin Florentine <[email protected]>
@jflo
typo in env var (hyperledger#6780)
bf03438 
* get value for sonar options from vars

---------

Signed-off-by: Justin Florentine <[email protected]>
@macfarla @jflo
for fcu v2 use correct invalid params error code (hyperledger#6766)
e3ea44e 
* fcu v2 use invalid params error code per spec

Signed-off-by: Sally MacFarlane <[email protected]>

---------

Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Justin Florentine <[email protected]>
@jflo
Cleanup dev releases (hyperledger#6782)
413e12e 
* delete develop release before creating new one

---------

Signed-off-by: Justin Florentine <[email protected]>
@macfarla @jflo
extra check for syncing (hyperledger#6771)
c2e5dc2 
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Justin Florentine <[email protected]>
@macfarla @jflo
updated PR template (hyperledger#6773)
5a6ab24 
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Justin Florentine <[email protected]>
@pinges @siladu @jflo
Fix "Backward sync stuck in a loop" hyperledger#6749 (hyperledger#6756)
1f62a28 
* minimal change to fix BWS

Signed-off-by: [email protected] <[email protected]>
Signed-off-by: Simon Dudley <[email protected]>
Co-authored-by: Simon Dudley <[email protected]>
Signed-off-by: Justin Florentine <[email protected]>
@usmansaleem @jflo
ci: Fix Publish GH workflow Artifactory secrets (hyperledger#6788)
3f1f322 
Signed-off-by: Usman Saleem <[email protected]>
Co-authored-by: Justin Florentine <[email protected]>
Signed-off-by: Justin Florentine <[email protected]>
@fab-10 @jflo
Improve PluginRpcEndpointException log (hyperledger#6789)
85aec93 
Signed-off-by: Fabio Di Fabio <[email protected]>
Signed-off-by: Justin Florentine <[email protected]>
@lucassaldanha @jflo
Adding engine_getPayloadV4 and engine_newPayloadV4 (hyperledger#6783)
bd2e18e 
Moved engine_newPayload6110 and engine_getPayload6110 to V4

Signed-off-by: Lucas Saldanha <[email protected]>
Signed-off-by: Justin Florentine <[email protected]>
@siladu @jflo
Refactor BackwardsSyncAlgorithm.pickNextStep for readability (hyperle…
894371e 
…dger#6775)

* Refactor BackwardsSyncAlgorithm.pickNextStep for readability

...mostly extracting methods

- Result null check
- Remove redundant BannedMethod suppressions
- Add sonar config back in that was removed by mistake

Signed-off-by: Simon Dudley <[email protected]>
Signed-off-by: Justin Florentine <[email protected]>
@jframe @jflo
Reduce receipt size (hyperledger#6602)
a5d69fd 
Signed-off-by: Jason Frame <[email protected]>
Signed-off-by: Justin Florentine <[email protected]>
@siladu @jflo
Remove draft config from develop release action (hyperledger#6807)
4373214 
Trying to get develop tag to be a pre-release

Signed-off-by: Simon Dudley <[email protected]>
Signed-off-by: Justin Florentine <[email protected]>
@siladu @jflo
Set noisy TransactionLogBloomCacher debug log to trace (hyperledger#6808
03d8a13 
)

Signed-off-by: Simon Dudley <[email protected]>
Signed-off-by: Justin Florentine <[email protected]>
@fab-10 @jflo
Support running executable Gradle tasks on Windows with WSL (hyperled…
a97108c 
…ger#6803)

Signed-off-by: Fabio Di Fabio <[email protected]>
Signed-off-by: Justin Florentine <[email protected]>
@matkt @jflo
Fix issues during snap sync (hyperledger#6802)
fccab7a 
The purpose of this commit is to fix some bugs detected in the snap sync. This should allow for greater stability with the snap sync and the healing of the flat DB.

---------

Signed-off-by: Karim Taam <[email protected]>
Signed-off-by: Justin Florentine <[email protected]>
@jflo
also fail on cancelled and skipped
e5c0446 
Signed-off-by: Justin Florentine <[email protected]>
@jflo jflo force-pushed the blockOnSkippedMatrix branch from 27891ff to e5c0446 Compare March 26, 2024 15:05
@jflo jflo closed this Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RoboCopsGoneSock RoboCopsGoneSock RoboCopsGoneSock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.