Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/only track intrinsically bad blocks #100

Closed
wants to merge 34 commits into from
Closed

Bug/only track intrinsically bad blocks #100

wants to merge 34 commits into from

Conversation

jflo
Copy link
Owner

@jflo jflo commented Mar 5, 2024

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Most advanced CI tests are deferred until PR approval, but you could:

  • locally run all unit tests via: ./gradlew build
  • locally run all acceptance tests via: ./gradlew acceptanceTest
  • locally run all integration tests via: ./gradlew integrationTest
  • locally run all reference tests via: ./gradlew ethereum:referenceTests:referenceTests

PR description

Fixed Issue(s)

mbaxter and others added 30 commits March 4, 2024 16:46
@mbaxter
TDD - add exceptional test cases, fix assertions
674e779 
Signed-off-by: mbaxter <[email protected]>
@mbaxter
Fix BlockValidator handling of bad blocks
ce2a9ea 
Signed-off-by: mbaxter <[email protected]>
@mbaxter
Clean up BadBlockManager
2e34005 
Signed-off-by: mbaxter <[email protected]>
@RoboCopsGoneSock @jflo @macfarla
Revert "Acceptance tests to use bonsai (hyperledger#6619)" (hyperledg…
412de29 
…er#6677)

This reverts commit 647750c.

Signed-off-by: Justin Florentine <[email protected]>
Co-authored-by: Justin Florentine <[email protected]>
Co-authored-by: Sally MacFarlane <[email protected]>
Signed-off-by: Justin Florentine <[email protected]>
@macfarla @jflo
adjust help message for --genesis-file (hyperledger#6654)
d07fe36 
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Justin Florentine <[email protected]>
@Gabriel-Trintinalia @jflo
Add blobs to eth_feeHistory (hyperledger#6679)
8909b7c 
Signed-off-by: Gabriel-Trintinalia <[email protected]>
Signed-off-by: Justin Florentine <[email protected]>
@macfarla @jflo
Eth call with 4844 params (hyperledger#6661)
1695e55 
* use accessList in hash and equals

* add blob fields to callParams

* blob fields from callParam used in transaction simulator

* don't zero maxFeePerBlobs if not present

* add roundtrip callParam verification

* added a failure case test

* error conversion

* added some spec tests

Signed-off-by: Sally MacFarlane <[email protected]>

---------

Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Justin Florentine <[email protected]>
@macfarla @jflo
[MINOR] Remove todo override genesis config (hyperledger#6659)
a10ced7 
* removed override param

Signed-off-by: Sally MacFarlane <[email protected]>

---------

Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Justin Florentine <[email protected]>
@fab-10 @jflo
Refactor and extend PluginTransactionPoolValidatorService (hyperledge…
39c15bc 
…r#6636)

Signed-off-by: Fabio Di Fabio <[email protected]>
Signed-off-by: Justin Florentine <[email protected]>
@jflo
sets metaspace explicitly after gradle reset a la gradle/gradle#19750
47f1a64 
Signed-off-by: Justin Florentine <[email protected]>
@jflo
allow manual runs of accept-test workflow
8e3ee63 
Signed-off-by: Justin Florentine <[email protected]>
@jflo
don't try to get prs that don't exist
3155ee2 
Signed-off-by: Justin Florentine <[email protected]>
@jflo
make artifacts more snapshot friendly
47b7534 
Signed-off-by: Justin Florentine <[email protected]>
@jflo
not javascript on those
3c2cfb9 
Signed-off-by: Justin Florentine <[email protected]>
@jflo
something on the windows runner changed
1994f06 
Signed-off-by: Justin Florentine <[email protected]>
@jflo
debugging stupid windows
9686220 
Signed-off-by: Justin Florentine <[email protected]>
@jflo
guess its powershell
827c83a 
Signed-off-by: Justin Florentine <[email protected]>
@jflo
avoid subdirs
28f27d7 
Signed-off-by: Justin Florentine <[email protected]>
@jflo
break out new workflows for snapshots, and a develop releease
9480654 
Signed-off-by: Justin Florentine <[email protected]>
@jflo
develop should be all we need
e183041 
Signed-off-by: Justin Florentine <[email protected]>
@jflo
only on main
b896487 
Signed-off-by: Justin Florentine <[email protected]>
@jflo
removes checking for approval, runs on pr update
c0e7174 
Signed-off-by: Justin Florentine <[email protected]>
@jflo
docker might need manual run
aa5f6d5 
Signed-off-by: Justin Florentine <[email protected]>
@jflo
Merge pull request #98 from jflo/gradleDaemonDisconnect
b222169 
Gradle daemon disconnect
@jflo
fixes job dependencies
754ac46 
Signed-off-by: Justin Florentine <[email protected]>
@jflo
Merge branch 'main' into gradleDaemonDisconnect
fad8fb1
@jflo
Merge pull request #99 from jflo/gradleDaemonDisconnect
efc7333 
fixes job dependencies
@jflo
adds concurrency so updated refs cancel prior runs if still running
7291430 
Signed-off-by: Justin Florentine <[email protected]>
@mbaxter
Generate a more readable toString method
9a9cfa2 
Signed-off-by: mbaxter <[email protected]>
@jflo
explicitly disable caching on gradle setup tasks
a9590f7 
Signed-off-by: Justin Florentine <[email protected]>
@jflo jflo closed this Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jflo @mbaxter @RoboCopsGoneSock @macfarla @Gabriel-Trintinalia @fab-10