Fixup FetchContent docs.
#91
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`copacabana` defaults to `${CMAKE_SOURCE_DIR}/test` when searching
for source files in `copa_glob_unit`, this will refer to the
top-level directory, ie the users project directory. The paths
of the sources will then be `../path-to-build/_deps/kumi-src/...`
and so on, in addition it might also match sources in the user
project.
Later `copa_make_unit` does `add_executable` with the same sources,
but these sources will be interpreter relative to the source
directory of the target, not `${CMAKE_SOURCE_DIR}/test` and then
no longer refer to an existing file.
Likely `copacabana` should refer to `${PROJECT_SOURCE_DIR}` instead
of `${CMAKE_SOURCE_DIR}` so that it is relative to the root of the
most recently declared projet, ie the one that is calling `copacabana`
functions. Until then disable `KUMI_BUILD_TEST` in the docs.
|
The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure GIT_TAG is set in FetchContent docs, else will default to
masterwhich doesn't exist.Temporarily disable
KUMI_BUILD_TEST. Not sure what the good default is forFetchContent, as I haven't used it much, but currently you might get errors when also building tests due to https://github.com/jfalcou/copacabana/blob/main/copacabana/cmake/make_unit.cmake#L135, see commit message in 612ec00 for details.Maybe instead of changing the
copacabanadefault (as suggested in the commit message), one could explicitly specify theOPT_RELATIVEinkumi.