Reworking jetty-compression for JPMS #12531
Open
+481
−490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbordet
requested changes
Nov 14, 2024
There was a problem hiding this comment.
I would also move to internal:
- oejc.server.CompressionResponse
- oejc.server.DecompressionRequest
Please also have a run across all the modules to fix simple warnings such as fields not used (e.g. CompressionResponse.LOG), fields that can be final, parameters not used (e.g. DecompressionRequest constructor), GzipCompression, etc.
jetty-core/jetty-compression/jetty-compression-brotli/src/main/java/module-info.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-compression/jetty-compression-zstandard/src/main/java/module-info.java
Outdated
Show resolved
Hide resolved
…mpression-module-info
sbordet
requested changes
Nov 15, 2024
...zip/src/main/java/org/eclipse/jetty/compression/gzip/internal/ConfiguredGzipInputStream.java
Outdated
Show resolved
Hide resolved
...-brotli/src/main/java/org/eclipse/jetty/compression/brotli/internal/BrotliDecoderSource.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-compression/jetty-compression-api/src/main/java/module-info.java
Outdated
Show resolved
Hide resolved
...mpression/jetty-compression-api/src/main/java/org/eclipse/jetty/compression/Compression.java
Show resolved
Hide resolved
...mpression/jetty-compression-api/src/main/java/org/eclipse/jetty/compression/EncoderSink.java
Show resolved
Hide resolved
jetty-core/jetty-compression/jetty-compression-server/src/main/java/module-info.java
Show resolved
Hide resolved
...compression-server/src/main/java/org/eclipse/jetty/compression/server/CompressionConfig.java
Show resolved
Hide resolved
...ompression-server/src/main/java/org/eclipse/jetty/compression/server/CompressionHandler.java
Show resolved
Hide resolved
...server/src/main/java/org/eclipse/jetty/compression/server/internal/DecompressionRequest.java
Outdated
Show resolved
Hide resolved
...ard/src/main/java/org/eclipse/jetty/compression/zstandard/internal/ZstandardEncoderSink.java
Show resolved
Hide resolved
|
Please also change all |
sbordet
requested changes
Nov 18, 2024
...re/jetty-compression/jetty-compression-brotli/src/main/config/modules/compression-brotli.mod
Outdated
Show resolved
Hide resolved
...re/jetty-compression/jetty-compression-common/src/main/config/modules/compression-common.mod
Outdated
Show resolved
Hide resolved
...compression-server/src/main/java/org/eclipse/jetty/compression/server/CompressionConfig.java
Outdated
Show resolved
Hide resolved
sbordet
requested changes
Nov 18, 2024
...re/jetty-compression/jetty-compression-brotli/src/main/config/modules/compression-brotli.mod
Outdated
Show resolved
Hide resolved
| @@ -178,7 +178,7 @@ public Set<String> getCompressIncludeMimeTypes() | |||
| * @see #getCompressExcludePaths() | |||
| */ | |||
| @ManagedAttribute("Set of Response Compression Path Exclusions") | |||
| public Set<String> getCompressPathIncludes() | |||
| public Set<String> getCompressIncludesPath() | |||
There was a problem hiding this comment.
Rename to getCompressIncludesPaths(), plural like the others.
There was a problem hiding this comment.
Doh! bad plural. :-/
sbordet
requested changes
Nov 18, 2024
…mpression-module-info
sbordet
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick reworking of jetty-compression for JPMS.