Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Switch default image to Venafi public registry #502

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hawksight
Copy link
Contributor

Now that Venafi has it's public registry with the venafi-agent image published, this naming makes more sense to align with this chart.

I'm leaving this in draft because now we have a version disparity between the chart version & the appVersion. I think Venafi product is keen to keep this in line, but this repository has no guidelines or process to ensure that.

Will discuss before making this ready to review.
For now we could bump some deps and release v0.1.44 of the container image and release this chart change in sync.
But I would rather we set a process for this.

@hawksight hawksight self-assigned this Jan 24, 2024
@achuchev
Copy link

@hawksight, I believe it's essential to maintain consistency across the image versions and Helm charts.

@hawksight
Copy link
Contributor Author

Thanks @achuchev for picking up the above.

I'm happy to go either way. But keeping them in sync might require some release process setup. I suggest we take that offline to setup.

This PR was just example where versions could become skewed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants