Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow functionAssociations overrides #230

Closed
wants to merge 2 commits into from

Conversation

coryasilva
Copy link

@coryasilva coryasilva commented Sep 12, 2024

Allows functionAssociations to be overriden resolving #229

@coryasilva coryasilva changed the title Allow functionAssociation overrides (resolves #229) feat: Allow functionAssociation overrides Sep 12, 2024
@coryasilva coryasilva changed the title feat: Allow functionAssociation overrides feat: Allow functionAssociations overrides Sep 12, 2024
@bestickley
Copy link
Contributor

bestickley commented Sep 12, 2024

@coryasilva, thanks for the PR. Want to merge but build is blocked. If you can resolve build, it will merge PR faster. Not sure if I'll have time to resolve this anytime soon.

@coryasilva
Copy link
Author

coryasilva commented Sep 12, 2024

@bestickley I am not very sure why it is failing, took 15 minutes to review it this morning but it was mostly just me learning more about projen... lol. Do you have any insights?

@bestickley Looks like this is the culprit. I bumped projen and did a build. Please trigger another ci run at your convenience.

@coryasilva coryasilva closed this Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants