Remove redundant pragmas

jet · Mar 4, 2022 · 0449ddb · 0449ddb
1 parent 5ef8376
commit 0449ddb
Show file tree

Hide file tree

Showing 9 changed files with 1 addition and 18 deletions.
diff --git a/README.md b/README.md
@@ -745,7 +745,7 @@ Ouch, not looking forward to reading all that logic :frown: ? [Have a read, it's
 
 > I'm having some trouble understanding how Equinox+ESDB handles "expected version". Most of the examples use `Equinox.Decider.Transact` which is storage agnostic and doesn't offer any obvious concurrency checking. In `Equinox.EventStore.Context`, there's a `Sync` and `TrySync` that take a `Token` which holds a `streamVersion`. Should I be be using that instead of `Transact`?
 
-The bulk of the implementation is in [`Equinox/Decider.fs`](https://github.com/jet/equinox/blob/master/src/Equinox/Decider.fs)
+The bulk of the implementation is in [`Equinox/Decider.fs`](https://github.com/jet/equinox/blob/master/src/Equinox/Decider.fs), see the `let run` function.
 
 There are [sequence diagrams in Documentation MD](https://github.com/jet/equinox/blob/master/DOCUMENTATION.md#code-diagrams-for-equinoxeventstore--equinoxsqlstreamstore) but I'll summarize here:
 

diff --git a/samples/Store/Integration/CartIntegration.fs b/samples/Store/Integration/CartIntegration.fs
@@ -5,8 +5,6 @@ open Equinox
 open Equinox.CosmosStore.Integration
 open Swensen.Unquote
 
-#nowarn "1182" // From hereon in, we may have some 'unused' privates (the tests)
-
 let fold, initial = Cart.Fold.fold, Cart.Fold.initial
 let snapshot = Cart.Fold.isOrigin, Cart.Fold.snapshot
 

diff --git a/samples/Store/Integration/ContactPreferencesIntegration.fs b/samples/Store/Integration/ContactPreferencesIntegration.fs
@@ -5,8 +5,6 @@ open Equinox
 open Equinox.CosmosStore.Integration
 open Swensen.Unquote
 
-#nowarn "1182" // From hereon in, we may have some 'unused' privates (the tests)
-
 let fold, initial = ContactPreferences.Fold.fold, ContactPreferences.Fold.initial
 
 let createMemoryStore () = MemoryStore.VolatileStore<_>()

diff --git a/samples/Store/Integration/FavoritesIntegration.fs b/samples/Store/Integration/FavoritesIntegration.fs
@@ -5,8 +5,6 @@ open Equinox
 open Equinox.CosmosStore.Integration
 open Swensen.Unquote
 
-#nowarn "1182" // From hereon in, we may have some 'unused' privates (the tests)
-
 let fold, initial = Favorites.Fold.fold, Favorites.Fold.initial
 let snapshot = Favorites.Fold.isOrigin, Favorites.Fold.snapshot
 

diff --git a/samples/Store/Integration/LogIntegration.fs b/samples/Store/Integration/LogIntegration.fs
@@ -95,8 +95,6 @@ let createLoggerWithMetricsExtraction emit =
  let capture = SerilogMetricsExtractor emit
  createLogger capture
 
-#nowarn "1182" // From hereon in, we may have some 'unused' privates (the tests)
-
 type Tests() =
  let act buffer (service : Cart.Service) itemCount context cartId skuId resultTag = async {
  do! CartIntegration.addAndThenRemoveItemsManyTimesExceptTheLastOne context cartId skuId service itemCount

diff --git a/tests/Equinox.CosmosStore.Integration/CosmosCoreIntegration.fs b/tests/Equinox.CosmosStore.Integration/CosmosCoreIntegration.fs
@@ -8,9 +8,6 @@ open Newtonsoft.Json.Linq
 open Swensen.Unquote
 open Serilog
 open System
-open System.Text
-
-#nowarn "1182" // From hereon in, we may have some 'unused' privates (the tests)
 
 type TestEvents() =
  static member private Create(i, ?eventType, ?json) =

diff --git a/tests/Equinox.CosmosStore.Integration/CosmosIntegration.fs b/tests/Equinox.CosmosStore.Integration/CosmosIntegration.fs
@@ -46,8 +46,6 @@ module ContactPreferences =
  let resolveStream = CosmosStoreCategory(context, codec, fold, initial, cachingStrategy, AccessStrategy.LatestKnownEvent).Resolve
  ContactPreferences.create log resolveStream
 
-#nowarn "1182" // From hereon in, we may have some 'unused' privates (the tests)
-
 type Tests(testOutputHelper) =
  inherit TestsWithLogCapture(testOutputHelper)
  let log,capture = base.Log, base.Capture

diff --git a/tests/Equinox.EventStore.Integration/StoreIntegration.fs b/tests/Equinox.EventStore.Integration/StoreIntegration.fs
@@ -86,8 +86,6 @@ module ContactPreferences =
  let cat = Category(createContext connection 1, codec, fold, initial, access = AccessStrategy.LatestKnownEvent)
  ContactPreferences.create log cat.Resolve
 
-#nowarn "1182" // From hereon in, we may have some 'unused' privates (the tests)
-
 type Tests(testOutputHelper) =
  let testOutput = TestOutputAdapter testOutputHelper
 

diff --git a/tests/Equinox.MemoryStore.Integration/MemoryStoreIntegration.fs b/tests/Equinox.MemoryStore.Integration/MemoryStoreIntegration.fs
@@ -9,8 +9,6 @@ let createServiceMemory log store =
  let cat = MemoryStoreCategory(store, FsCodec.Box.Codec.Create(), Cart.Fold.fold, Cart.Fold.initial)
  Cart.create log cat.Resolve
 
-#nowarn "1182" // From hereon in, we may have some 'unused' privates (the tests)
-
 type Tests(testOutputHelper) =
  let testOutput = TestOutputAdapter testOutputHelper
  let createLog () = createLogger testOutput