Skip to content

Commit

Permalink
Fix erroneous acks xmldoc
Browse files Browse the repository at this point in the history
  • Loading branch information
bartelink committed Dec 11, 2020
1 parent 9719c66 commit d581594
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 14 deletions.
10 changes: 3 additions & 7 deletions src/FsKafka/FsKafka.fs
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,7 @@ type KafkaProducerConfig private (inner, bootstrapServers : string) =

/// Creates and wraps a Confluent.Kafka ProducerConfig with the specified settings
static member Create
( clientId : string, bootstrapServers : string,
/// Default: All
acks,
( clientId : string, bootstrapServers : string, acks,
/// Defines combination of linger/maxInFlight settings to effect desired batching semantics
batching : Batching,
/// Message compression. Default: None.
Expand All @@ -58,7 +56,7 @@ type KafkaProducerConfig private (inner, bootstrapServers : string) =
?retryBackoff,
/// Statistics Interval. Default: no stats.
?statisticsInterval,
/// Ack timeout (assuming Acks != Acks.0). Confluent.Kafka default: 5s.
/// Ack timeout (assuming Acks != Acks.Zero). Confluent.Kafka default: 5s.
?requestTimeout,
/// Confluent.Kafka default: false. Defaults to true.
?socketKeepAlive,
Expand Down Expand Up @@ -97,9 +95,7 @@ type KafkaProducerConfig private (inner, bootstrapServers : string) =
[<Obsolete "linger is now mandatory as a result of Confluent.Kafka 1.5's changing the default from 0.5ms to 5ms">]
// TODO remove in 2.0.0
static member Create
( clientId : string, bootstrapServers : string,
/// Default: All
acks,
( clientId : string, bootstrapServers : string, acks,
/// Message compression. Default: None.
?compression,
/// Maximum in-flight requests. Default: 1_000_000.
Expand Down
10 changes: 3 additions & 7 deletions src/FsKafka0/FsKafka.fs
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,7 @@ type KafkaProducerConfig private (inner, bootstrapServers : string) =

/// Creates and wraps a Confluent.Kafka ProducerConfig with the specified settings
static member Create
( clientId : string, bootstrapServers : string,
/// Default: All
acks,
( clientId : string, bootstrapServers : string, acks,
/// Defines combination of linger/maxInFlight settings to effect desired batching semantics
batching : Batching,
/// Message compression. Default: None.
Expand Down Expand Up @@ -97,9 +95,7 @@ type KafkaProducerConfig private (inner, bootstrapServers : string) =
[<Obsolete "linger is now mandatory as a result of Confluent.Kafka 1.5's changing the default from 0.5ms to 5ms">]
// TODO remove in 2.0.0
static member Create
( clientId : string, bootstrapServers : string,
/// Default: All
acks,
( clientId : string, bootstrapServers : string, acks,
/// Message compression. Default: None.
?compression,
/// Maximum in-flight requests. Default: 1_000_000.
Expand All @@ -114,7 +110,7 @@ type KafkaProducerConfig private (inner, bootstrapServers : string) =
?retryBackoff,
/// Statistics Interval. Default: no stats.
?statisticsInterval,
/// Ack timeout (assuming Acks != Acks.0). Confluent.Kafka default: 5s.
/// Ack timeout (assuming Acks != Acks.Zero). Confluent.Kafka default: 5s.
?requestTimeout,
/// Confluent.Kafka default: false. Defaults to true.
?socketKeepAlive,
Expand Down

0 comments on commit d581594

Please sign in to comment.