reqwest stream!? #153
Merged
reqwest stream!? #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
big feat is async streaming of reqwests... now that that is out of the way the rest should be straight ish forward?
AI WORD SALAD (which totally did not pick up on the reqwest stream stuff)
This pull request includes several changes to the
ryo3-reqwestcrate, focusing on enhancing the functionality of asynchronous and blocking HTTP clients, improving code readability, and updating dependencies. The most important changes include the addition of new HTTP methods, restructuring of response handling, and cleanup of theCargo.tomlfiles.Enhancements to HTTP clients:
crates/ryo3-reqwest/src/async_client.rs: Added new HTTP methods (put,patch,delete,head) and implemented a response-consuming async iterator for the response body. [1] [2] [3]crates/ryo3-reqwest/src/blocking.rs: Added new HTTP methods (put,patch,delete,head) and restructured theRyBlockingResponsestruct to include additional response metadata. [1] [2]Code cleanup and improvements:
crates/ryo3-reqwest/src/lib.rs: Removed commented-out code and unused imports to improve readability.crates/ryo3-reqwest/src/pyo3_bytes.rs: Refactored thePyo3JsonBytesstruct and removed commented-out code. [1] [2]Dependency updates:
crates/ryo3-reqwest/Cargo.toml: Updated thereqwestdependency to include additional features and added new dependencies (futures-core,futures-util).Miscellaneous:
Cargo.toml: Added comments and notes regarding theltooption in the release profile.