Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pyetrade/automatedTrading.py #65

Closed
wants to merge 1 commit into from
Closed

Conversation

mw66
Copy link
Contributor

@mw66 mw66 commented Jun 13, 2022

@mw66
Copy link
Contributor Author

mw66 commented Jun 13, 2022

@jessecooper

This will properly close: #63 #56 #62

@jessecooper
Copy link
Owner

Hi @mw66, I truly appreciate the PR as the feature has been requested a lot but like I said in #63 this feature is outside of the scope of the Etrade API and further might even violate the terms & conditions of Etrade (I am unsure of this). That is why I encouraged this to be moved into the Discussions. This would also bring in some heavy new requirements into the project that are not called out in the PR selenium and pandas. There are other ways to implement this with just bs4. I am going to close this out and if you would like to put this in a Gist and post it in the discussion that would probably be a better place for it than directly in the project. The scope of pyetrade is to be a Python binding to the Etrade API. Other logic is the responsibility of the application that imports pyetrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants