Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crypto.com exchange added for backtesting #482

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gabe777
Copy link

@gabe777 gabe777 commented Oct 18, 2024

Summary

This PR adds support for Crypto.com Spot and Perpetual Futures exchanges, allowing backtesting and candle imports for both. The new options are integrated into the existing Candle Import and Backtesting interfaces.
I needed the exchange for my own backtesting purposes and thought it would be useful to others too.

Changes

  • Added new classes to handle API access for both Crypto.com Spot and Perpetual Futures.
  • Updated the necessary config and enums to ensure these new exchanges show up as selectable options, without changing the overall behavior of the application.

Testing

  • Wrote pytests to cover the new classes in import_candles_mode.

Notes

  • I added entries for Crypto.com Exchange in info.py exchange_info. The live_trading option is set to False since I haven't implemented that part, though it would be great to have it. :)
  • Regarding the fee attribute, since Crypto.com has a progressive fee structure with different maker/taker rates, I opted to use the highest fee. This way, backtesting results will err on the side of caution (better to show worse performance than better-than-real).

Copy link

stale bot commented Dec 18, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale No recent activity. label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale No recent activity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant