Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FutureExchange): iterate the orders from the end makes the simulation run faster #430

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions jesse/models/FuturesExchange.py
Original file line number Diff line number Diff line change
Expand Up @@ -155,13 +155,15 @@ def on_order_cancellation(self, order: Order) -> None:
if not order.reduce_only:
if order.side == sides.BUY:
# find and set order to [0, 0] (same as removing it)
for index, item in enumerate(self.buy_orders[base_asset]):
for index in range(len(self.buy_orders[base_asset]) - 1, 0, -1):
item = self.buy_orders[base_asset][index]
if item[0] == order.qty and item[1] == order.price:
self.buy_orders[base_asset][index] = np.array([0, 0])
break
else:
# find and set order to [0, 0] (same as removing it)
for index, item in enumerate(self.sell_orders[base_asset]):
for index in range(len(self.sell_orders[base_asset]) - 1, 0, -1):
item = self.sell_orders[base_asset][index]
if item[0] == order.qty and item[1] == order.price:
self.sell_orders[base_asset][index] = np.array([0, 0])
break
Expand Down
Loading