Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use fastify #661

Merged
merged 29 commits into from
Dec 6, 2023
Merged

refactor: use fastify #661

merged 29 commits into from
Dec 6, 2023

Conversation

trim21
Copy link
Collaborator

@trim21 trim21 commented Jul 31, 2023

Description

use @fastify/express to wrap express with fastify.

will migrate express handlers to fastify handlers progressively

Related Issue

Screenshots

Types of changes

  • Breaking change (changes that break backward compatibility of public API or CLI - semver MAJOR)
  • New feature (non-breaking change which adds functionality - semver MINOR)
  • Bug fix (non-breaking change which fixes an issue - semver PATCH)

@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Attention: 45 lines in your changes are missing coverage. Please review.

Comparison is base (6d05954) 77.15% compared to head (210fb7b) 72.27%.

Files Patch % Lines
server/routes/index.ts 67.15% 45 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #661      +/-   ##
==========================================
- Coverage   77.15%   72.27%   -4.88%     
==========================================
  Files          62       62              
  Lines       11376    11384       +8     
  Branches     1286      937     -349     
==========================================
- Hits         8777     8228     -549     
- Misses       2583     3142     +559     
+ Partials       16       14       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trim21 trim21 marked this pull request as ready for review July 31, 2023 05:41
@trim21 trim21 changed the title [WIP]refactor: use fastify refactor: use fastify Jul 31, 2023
@trim21 trim21 requested a review from jesec December 6, 2023 11:39
@trim21 trim21 enabled auto-merge (squash) December 6, 2023 11:43
@trim21 trim21 disabled auto-merge December 6, 2023 11:44
@trim21 trim21 enabled auto-merge (squash) December 6, 2023 11:46
@trim21 trim21 merged commit a570469 into jesec:master Dec 6, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant