build: migrate to pnpm (#772)

.github/workflows/build.yml

@@ -9,23 +9,36 @@ on:
       - master
 
 jobs:
-  build:
-    runs-on: ubuntu-20.04
+  build-real:
+    runs-on: ubuntu-24.04
 
     strategy:
       matrix:
-        node: [18, 20]
+        node: ['20', '22']
       fail-fast: false
 
     steps:
       - uses: actions/checkout@v4
 
+      - uses: pnpm/action-setup@v4
       - name: Use Node.js ${{ matrix.node }}
         uses: actions/setup-node@v4
         with:
           node-version: ${{ matrix.node }}
-          cache: 'npm'
+          cache: 'pnpm'
 
-      - run: npm ci
+      - run: pnpm install --frozen-lockfile
       - run: npm run build
       - run: npm run start -- --help
+
+  build:
+    # so we do not need to update GitHub repo config
+    needs: build-real
+    runs-on: ubuntu-latest
+
+    strategy:
+      matrix:
+        node: ['18', '20']
+      fail-fast: false
+    steps:
+      - run: echo pass

.github/workflows/check.yml

@@ -9,23 +9,36 @@ on:
       - master
 
 jobs:
-  check:
-    runs-on: ubuntu-20.04
+  check-real:
+    runs-on: ubuntu-24.04
 
     strategy:
       fail-fast: false
       matrix:
-        node: [20]
+        node: ['22']
         check: [check-source-formatting, check-types, lint]
 
     steps:
       - uses: actions/checkout@v4
-
+      - uses: pnpm/action-setup@v4
       - name: Use Node.js ${{ matrix.node }}
         uses: actions/setup-node@v4
         with:
           node-version: ${{ matrix.node }}
-          cache: npm
+          cache: 'pnpm'
 
-      - run: npm ci
+      - run: pnpm install --frozen-lockfile
       - run: npm run ${{ matrix.check }}
+
+  check:
+    # so we do not need to update GitHub repo config
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        node: ['20']
+        check: [check-source-formatting, check-types, lint]
+    needs:
+      - check-real
+    steps:
+      - run: echo ok

.github/workflows/codeql-analysis.yml

@@ -13,7 +13,7 @@ on:
 jobs:
   analyze:
     name: Analyze
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-24.04
 
     strategy:
       fail-fast: false
@@ -27,15 +27,6 @@ jobs:
     steps:
       - name: Checkout repository
         uses: actions/checkout@v4
-        with:
-          # We must fetch at least the immediate parents so that if this is
-          # a pull request then we can checkout the head.
-          fetch-depth: 2
-
-      # If this run was triggered by a pull request event, then checkout
-      # the head of the pull request instead of the merge commit.
-      - run: git checkout HEAD^2
-        if: ${{ github.event_name == 'pull_request' }}
 
       # Initializes the CodeQL tools for scanning.
       - name: Initialize CodeQL

.github/workflows/distribute-archlinux.yml

@@ -9,7 +9,7 @@ on:
 
 jobs:
   aur:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-24.04
     steps:
       - uses: actions/checkout@v4
 

.github/workflows/distribute-debian.yml

@@ -9,21 +9,22 @@ on:
 
 jobs:
   flood-bin:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-24.04
 
     strategy:
       matrix:
-        node: [20]
+        node: ['22']
 
     steps:
       - uses: actions/checkout@v4
 
+      - uses: pnpm/action-setup@v4
       - name: Use Node.js ${{ matrix.node }}
         uses: actions/setup-node@v4
         with:
           node-version: ${{ matrix.node }}
           registry-url: 'https://registry.npmjs.org'
-          cache: npm
+          cache: 'pnpm'
 
       - name: Set up QEMU
         run: |

.github/workflows/publish-rolling.yml

@@ -7,23 +7,25 @@ on:
 
 jobs:
   npm:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-24.04
 
     strategy:
       matrix:
-        node: [20]
+        node: ['22']
 
     steps:
       - uses: actions/checkout@v4
 
+      - uses: pnpm/action-setup@v4
+
       - name: Use Node.js ${{ matrix.node }}
         uses: actions/setup-node@v4
         with:
           node-version: ${{ matrix.node }}
           registry-url: 'https://registry.npmjs.org'
-          cache: npm
+          cache: pnpm
 
-      - run: npm ci
+      - run: pnpm install --frozen-lockfile
 
       - name: Tag rolling release
         id: tag_release
@@ -64,7 +66,7 @@ jobs:
 
   docker:
     needs: npm
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-24.04
 
     steps:
       - uses: actions/checkout@v4
@@ -115,11 +117,11 @@ jobs:
             RTORRENT_VERSION=master
 
   docker-dbg:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-24.04
 
     strategy:
       matrix:
-        node: [20]
+        node: ['22']
 
     steps:
       - uses: actions/checkout@v4
@@ -129,7 +131,7 @@ jobs:
         with:
           node-version: ${{ matrix.node }}
           registry-url: 'https://registry.npmjs.org'
-          cache: npm
+          cache: 'pnpm'
 
       - name: Set up QEMU
         uses: docker/setup-qemu-action@v3
@@ -171,11 +173,11 @@ jobs:
 
   pkg:
     needs: npm
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-24.04
 
     strategy:
       matrix:
-        node: [20]
+        node: ['22']
 
     steps:
       - name: Use Node.js ${{ matrix.node }}
@@ -256,7 +258,7 @@ jobs:
 
   docker-distroless:
     needs: pkg
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-24.04
 
     steps:
       - uses: actions/checkout@v4

.github/workflows/release.yml

@@ -7,7 +7,7 @@ on:
 
 jobs:
   release:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-24.04
 
     strategy:
       matrix:
@@ -16,15 +16,17 @@ jobs:
     steps:
       - uses: actions/checkout@v4
 
+      - uses: pnpm/action-setup@v4
+
       - name: Use Node.js ${{ matrix.node }}
         uses: actions/setup-node@v4
         with:
-          node-version: ${{ matrix.node }}
+          node-version: ${{ matrix.node + 2 }}
           registry-url: 'https://registry.npmjs.org'
-          cache: npm
+          cache: 'pnpm'
 
       - run: sudo npm i -g pkg
-      - run: npm ci
+      - run: pnpm install --frozen-lockfile
 
       - run: npm publish --access public
         env:
@@ -70,7 +72,7 @@ jobs:
 
   release-docker:
     needs: release
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-24.04
     steps:
       - uses: actions/checkout@v4
 

.github/workflows/test-backend.yml

@@ -9,22 +9,23 @@ on:
       - master
 
 jobs:
-  test-backend:
+  test-backend-real:
     runs-on: ubuntu-22.04
 
     strategy:
       matrix:
-        node: ['18', '20']
+        node: ['20', '22']
       fail-fast: false
 
     steps:
       - uses: actions/checkout@v4
+      - uses: pnpm/action-setup@v4
 
       - name: Use Node.js ${{ matrix.node }}
         uses: actions/setup-node@v4
         with:
           node-version: ${{ matrix.node }}
-          cache: npm
+          cache: 'pnpm'
 
       - run: sudo add-apt-repository -y ppa:qbittorrent-team/qbittorrent-stable
       - run: sudo add-apt-repository -y ppa:transmissionbt/ppa
@@ -34,7 +35,7 @@ jobs:
           wget https://github.com/jesec/rtorrent/releases/latest/download/rtorrent-linux-amd64.deb
           sudo dpkg -i rtorrent-linux-amd64.deb
 
-      - run: npm ci
+      - run: pnpm install --frozen-lockfile
       - run: npm test || npm test || npm test
 
       - uses: codecov/codecov-action@v3
@@ -46,3 +47,16 @@ jobs:
 
       - run: npm test -- --selectProjects rtorrent || npm test -- --selectProjects rtorrent || npm test -- --selectProjects rtorrent
         if: matrix['node'] == '20'
+
+  test-backend:
+    # so we do not need to update GitHub repo config
+    runs-on: ubuntu-latest
+    needs:
+      - test-backend-real
+    strategy:
+      matrix:
+        node: ['18', '20']
+      fail-fast: false
+
+    steps:
+      - run: echo pass

.github/workflows/translations.yml

@@ -10,7 +10,7 @@ on:
 jobs:
   synchronize-with-crowdin:
     if: github.repository_owner == 'jesec'
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-24.04
 
     steps:
       - uses: actions/checkout@v4

.prettierignore

@@ -4,3 +4,4 @@ dist-pkg/
 
 # Coverage reports
 coverage/
+pnpm-lock.yaml

Dockerfile

@@ -21,7 +21,7 @@ WORKDIR /usr/src/app/
 COPY . ./
 
 # Fetch dependencies from npm
-RUN npm ci --legacy-peer-deps
+RUN pnpm install --frozen-lockfile --legacy-peer-deps
 
 # Build assets
 RUN npm run build

client/src/javascript/components/modals/settings-modal/AboutTab.tsx

@@ -1,8 +1,8 @@
-import {FC, lazy, Suspense} from 'react';
+import {ComponentType, FC, lazy, Suspense} from 'react';
 
 import packageJSON from '../../../../../../package.json';
 
-const AboutMarkdown = lazy(() =>
+const AboutMarkdown = lazy<ComponentType<{FloodVersion: unknown; CommitBadge: unknown}>>(() =>
   import(/* webpackChunkName: 'about' */ '../../../../ABOUT.md').then((module) => ({default: module.react})),
 );
 

client/src/javascript/components/sidebar/LogoutButton.tsx

@@ -1,6 +1,7 @@
-import {ClassNamesArg, cx} from '@emotion/css';
+import {cx} from '@emotion/css';
 import {FC} from 'react';
 import {useLingui} from '@lingui/react';
+import {ClassNamesArg} from '@emotion/react';
 
 import AuthActions from '@client/actions/AuthActions';
 import ConfigStore from '@client/stores/ConfigStore';

distribution/containers/Dockerfile.release

@@ -1,5 +1,5 @@
 # Use node alpine docker image
-FROM docker.io/node:alpine
+FROM docker.io/node:22-alpine
 
 ARG PACKAGE=flood
 ARG VERSION=latest