Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement optional chaining #5164

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gergocs
Copy link
Contributor

@gergocs gergocs commented Nov 14, 2024

The work is based on PR #4843, only fixed some conflicts and cppcheck errors.

Co-authored-by: Robert Fancsik [email protected]
Signed-off-by: Gergo Csizi [email protected]

@gergocs gergocs force-pushed the optionalChainingFix branch 4 times, most recently from 532e122 to ec873d7 Compare November 15, 2024 08:50
Copy link
Contributor

@LaszloLango LaszloLango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a little bit worrying about the performance impact of this change. It would nice if we can make sure there is no regression in performance after this change.

jerry-core/parser/js/js-lexer.c Outdated Show resolved Hide resolved
jerry-core/vm/vm.c Outdated Show resolved Hide resolved
jerry-core/parser/js/js-parser-expr.c Outdated Show resolved Hide resolved
jerry-core/parser/js/js-parser-expr.c Outdated Show resolved Hide resolved
The work is based on PR jerryscript-project#4843, only fixed some conflicts and cppcheck errors.

Co-authored-by: Robert Fancsik [email protected]
JerryScript-DCO-1.0-Signed-off-by: Gergo Csizi [email protected]
Copy link
Contributor

@LaszloLango LaszloLango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants