-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework internal methods #4968
Open
szilagyiadam
wants to merge
1
commit into
jerryscript-project:master
Choose a base branch
from
szilagyiadam:rework_internal_methods
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Rework internal methods #4968
szilagyiadam
wants to merge
1
commit into
jerryscript-project:master
from
szilagyiadam:rework_internal_methods
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Created virtual function tables for internal methods and call the specialized internal function for the object instead of the generic one which operates based on a switch by the object type - Generalize ecma_property_descriptor_t to handle virtual and general properties - Separate the new virtual internal methods into the corresponding .c file Co-authored-by: Robert Fancsik [email protected] JerryScript-DCO-1.0-Signed-off-by: Adam Szilagyi [email protected]
rerobika
force-pushed
the
rework_internal_methods
branch
from
January 20, 2022 11:24
3953f09
to
5ac777e
Compare
benchmark test on RPI2: var a = [];
a.length = 11000;
for (var i = 0; i < 10000; i++) {
a[i] = i;
}
for (var i = 0; i < 5000; i++) {
a.reverse();
a.reverse();
a.reverse();
a.reverse();
a.reverse();
a.reverse();
a.reverse();
a.reverse();
a.reverse();
a.reverse();
} Before: 4m30s |
rerobika
added
performance
Affects performance
stack usage
Affects stack usage
ecma core
Related to core ECMA functionality
labels
Jan 20, 2022
|
robertsipka
added
discussion
Ongoing discussion
and removed
discussion
Ongoing discussion
labels
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ecma core
Related to core ECMA functionality
performance
Affects performance
stack usage
Affects stack usage
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Robert Fancsik [email protected]
JerryScript-DCO-1.0-Signed-off-by: Adam Szilagyi [email protected]