Add disableClick option back and release v2.0.1

jerrybendy · Nov 9, 2019 · 2f42a75 · 2f42a75
1 parent 5deaaeb
commit 2f42a75
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 11 deletions.
diff --git a/README.md b/README.md
@@ -76,13 +76,20 @@ In your `.vue` file:
 
 ```js
 Vue.use(Vue2TouchEvents, {
+    disableClick: false,
     touchClass: '',
     tapTolerance: 10,
     swipeTolerance: 30,
     longTapTimeInterval: 400
 })
 ```
 
+* `disableClick` default `false`. Use touch event only, will not trigger click event.
+
+    You should keep this value default if you use your website on both mobile and PC.
+
+    If your website uses on mobile only, it's a good choice to set this value to `true` to get a better user experience, and it can resolve some touch pass-through issue.
+
 * `touchClass`  default: `''`. Add an extra CSS class when touch start, and remove it when touch end.
 
     This is a global config, and you can use `v-touch-class` directive to overwrite this setting in a single component.

diff --git a/index.js b/index.js
@@ -269,11 +269,13 @@ var vueTouchEvents = {
                 $el.addEventListener('touchcancel', touchCancelEvent)
                 $el.addEventListener('touchend', touchEndEvent)
 
-                $el.addEventListener('mousedown', touchStartEvent)
-                $el.addEventListener('mousemove', touchMoveEvent)
-                $el.addEventListener('mouseup', touchEndEvent)
-                $el.addEventListener('mouseenter', mouseEnterEvent)
-                $el.addEventListener('mouseleave', mouseLeaveEvent)
+                if (!options.disableClick) {
+                    $el.addEventListener('mousedown', touchStartEvent)
+                    $el.addEventListener('mousemove', touchMoveEvent)
+                    $el.addEventListener('mouseup', touchEndEvent)
+                    $el.addEventListener('mouseenter', mouseEnterEvent)
+                    $el.addEventListener('mouseleave', mouseLeaveEvent)
+                }
 
                 // set bind mark to true
                 $el.$$touchObj.hasBindTouchEvents = true
@@ -285,11 +287,13 @@ var vueTouchEvents = {
                 $el.removeEventListener('touchcancel', touchCancelEvent)
                 $el.removeEventListener('touchend', touchEndEvent)
 
-                $el.removeEventListener('mousedown', touchStartEvent)
-                $el.removeEventListener('mousemove', touchMoveEvent)
-                $el.removeEventListener('mouseup', touchEndEvent)
-                $el.removeEventListener('mouseenter', mouseEnterEvent)
-                $el.removeEventListener('mouseleave', mouseLeaveEvent)
+                if (!options.disableClick) {
+                    $el.removeEventListener('mousedown', touchStartEvent)
+                    $el.removeEventListener('mousemove', touchMoveEvent)
+                    $el.removeEventListener('mouseup', touchEndEvent)
+                    $el.removeEventListener('mouseenter', mouseEnterEvent)
+                    $el.removeEventListener('mouseleave', mouseLeaveEvent)
+                }
 
                 // remove vars
                 delete $el.$$touchObj

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "vue2-touch-events",
-  "version": "2.0.0",
+  "version": "2.0.1",
   "description": "Simple touch events support for vueJS2",
   "main": "index.js",
   "types": "index.d.ts",