Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile #9

Closed
hyanwong opened this issue Mar 8, 2023 · 5 comments
Closed

Makefile #9

hyanwong opened this issue Mar 8, 2023 · 5 comments

Comments

@hyanwong
Copy link
Collaborator

hyanwong commented Mar 8, 2023

It would be handy for someone other than me to write a makefile for the figures in the repo ('cos I'm rubbish at writing Makefiles, and it will take me ages).

From my point of view, we would assume that the two files upgma-mds-1000-md-30-mm-3-2022-06-30-recinfo-il.ts.tsz and upgma-full-md-30-mm-3-2021-06-30-recinfo-il.ts.tsz will have been put in the data/ directory by the user, and the Dendroscope and chromium binaries are available somewhere (I'm not sure how to encode that in the plot.py file: currently it's hardcoded, sorry). Everything else can be automated, I hope. This includes:

Obviously the locations of the stored files, names of directories, etc can be changed in whatever way seems most logical.

@jeromekelleher
Copy link
Owner

I agree, good to systematise this.

@jeromekelleher
Copy link
Owner

I'll have a go if I get a chance.

@jeromekelleher
Copy link
Owner

It would be nice to do this, but I think we should pull some of the code in the plots.py into notebooks, following the other sections. In particular, we should run dendroscope and store the newicks in the git repo (in the data dir).

Running the plots should only take a few seconds, anything that requires computation should be done in a notebook and cached.

I've added some automation in the notebooks directory for running the notebooks, and some of these already export data files. We can further systematise then.

@hyanwong
Copy link
Collaborator Author

hyanwong commented Jun 1, 2023

in particular, we should run dendroscope and store the newicks in the git repo (in the data dir)

Yeah, good plan. Shall I make an extra notebook for this, then? Or I guess I could add it into the (already existing) Cophylo-treecmp.ipynb

@jeromekelleher
Copy link
Owner

Whichever makes most sense. Note updated notebook names (coinciding with section number for findability) though

@hyanwong hyanwong closed this as completed Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants