Added arg jailbroken method to allow for disabling RootBeer logging #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpyke1: added arg for setLogging to jailbroken
bpyke1: fixed argument ref
bpyke1: adjusted arg
Bpyke1: fixed args
|
Can this be reviewed and merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had some feedback on our application that the logging from RootBeer that appears in LogCat on Android was a minor security risk that could help attackers implementing a root detection bypass.
I added an argument to the jailbroken method to set the RootBeer setLogging method.
Open to any feedback on the change!