-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: (BREAKING) v2.1.0, attempt to fix waa edge-case, upgrade dependencies #24
Conversation
e5a77aa
to
8df70e5
Compare
@Moseco I've implemented the Hepburn change, but it works differently thank you might expect. In katakana, From the docs from the
|
@jeroen-meijer Cool, thanks for implementing the changes! One other thing. Since I originally made the PR to fix the rare kana issue I also added support for converting |
@Moseco Got it, thanks. I think that might describe a different edge-case, right? I'll go ahead and merge this for now and do a release to unblock other projects. If this pops up as an issue, you or someone else can make a ticket for it. |
Description
This PR does the following:
3.0.0
.package:equatable
dependency.Related issues and PRs
Closes #18
Closes #19
Closes #22
Closes #23