Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: (BREAKING) v2.1.0, attempt to fix waa edge-case, upgrade dependencies #24

Merged
merged 9 commits into from
Sep 25, 2024

Conversation

jeroen-meijer
Copy link
Owner

@jeroen-meijer jeroen-meijer commented Sep 23, 2024

Description

This PR does the following:

  • Fix シークヮーサー and シマウヮー conversion edge-cases (thanks to @Moseco and @HighLiuk)
  • Change minimum required Dart version to 3.0.0.
  • Add FVM config.
  • Add CSpell spell checking config.
  • Remove package:equatable dependency.
  • Upgrade dependencies.
  • Upgrade all dev dependencies and linter.

Related issues and PRs

Closes #18
Closes #19
Closes #22
Closes #23

@jeroen-meijer jeroen-meijer added the feat A feature or enhancement. label Sep 23, 2024
@jeroen-meijer jeroen-meijer self-assigned this Sep 23, 2024
@jeroen-meijer jeroen-meijer marked this pull request as ready for review September 24, 2024 13:18
@jeroen-meijer
Copy link
Owner Author

@Moseco I've implemented the Hepburn change, but it works differently thank you might expect.

In katakana, シークヮーサー correctly becomes shiikuwaasaa.
In hiragana, しーくゎーさー becomes shi-kuwa-sa-, which is also correct and conforms to how the library converts the when used in hiragana.

From the docs from the KanaKit.toRomaji function:

Converts all kana characters of the [input] to romaji.

The [input] String cannot be null. If an empty String is provided, an empty String will be returned immediately.

If this [config]'s [KanaKitConfig.upcaseKatakana] is true, katakana characters will be converted to uppercase characters. ignored.

// With KanaKitConfig.upcaseKatakana == false (default)
toRomaji('ひらがな カタカナ'); // "hiragana katakana"
toRomaji('げーむ ゲーム'); // "ge-mu geemu"
// With KanaKitConfig.upcaseKatakana == true
toRomaji('ひらがな カタカナ'); // "hiragana KATAKANA"
toRomaji('げーむ ゲーム'); // "ge-mu GEEMU"

@jeroen-meijer jeroen-meijer changed the title feat: v2.1.0, attempt to fix waa edge-case, upgrade dependencies feat!: (BREAKING) v2.1.0, attempt to fix waa edge-case, upgrade dependencies Sep 24, 2024
@Moseco
Copy link

Moseco commented Sep 25, 2024

@jeroen-meijer Cool, thanks for implementing the changes!

One other thing. Since I originally made the PR to fix the rare kana issue I also added support for converting found in katakana to a hyphen - when using toRomagi. Previously it would just throw an error if did not follow a supported vowel. It looks that is included in this branch too. If you want to keep that we can add it to the changelog and make a test for it. The only word I have ever seen with it is パンピアンーミンドリン/Pumpian-Mindlin from enamdict (proper noun dictionary).

@jeroen-meijer
Copy link
Owner Author

@Moseco Got it, thanks. I think that might describe a different edge-case, right?

I'll go ahead and merge this for now and do a release to unblock other projects. If this pops up as an issue, you or someone else can make a ticket for it.

@jeroen-meijer jeroen-meijer merged commit a5fea6e into master Sep 25, 2024
2 checks passed
@jeroen-meijer jeroen-meijer deleted the feat/v2.1.0-upgrades branch September 26, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat A feature or enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for dart 3.x Conversion problem with toRomaji function
2 participants