[ES|QL] Improves application messages (elastic#168078)

jeramysoucy · Oct 5, 2023 · e430a7f · e430a7f
1 parent cee55e3
commit e430a7f
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 8 deletions.
diff --git a/packages/kbn-es-query/src/es_query/es_aggregate_query.ts b/packages/kbn-es-query/src/es_query/es_aggregate_query.ts
@@ -28,8 +28,9 @@ export function getAggregateQueryMode(query: AggregateQuery): Language {
   return Object.keys(query)[0] as Language;
 }
 
-export function getLanguageDisplayName(language: string): string {
-  return language === 'esql' ? 'es|ql' : language;
+export function getLanguageDisplayName(language?: string): string {
+  const displayName = language && language === 'esql' ? 'es|ql' : language ?? 'es|ql';
+  return displayName.toUpperCase();
 }
 
 // retrieves the index pattern from the aggregate query for SQL

diff --git a/packages/kbn-text-based-editor/src/text_based_languages_editor.tsx b/packages/kbn-text-based-editor/src/text_based_languages_editor.tsx
@@ -580,7 +580,7 @@ export const TextBasedLanguagesEditor = memo(function TextBasedLanguagesEditor({
                 {documentationSections && (
                   <EuiFlexItem grow={false}>
                     <LanguageDocumentationPopover
-                      language={getLanguageDisplayName(String(language)).toUpperCase()}
+                      language={getLanguageDisplayName(String(language))}
                       sections={documentationSections}
                       buttonProps={{
                         color: 'text',

diff --git a/src/plugins/unified_search/public/dataview_picker/change_dataview.tsx b/src/plugins/unified_search/public/dataview_picker/change_dataview.tsx
@@ -120,7 +120,7 @@ export function ChangeDataView({
 
   useEffect(() => {
     if (textBasedLanguage) {
-      setTriggerLabel(getLanguageDisplayName(textBasedLanguage).toUpperCase());
+      setTriggerLabel(getLanguageDisplayName(textBasedLanguage));
     } else {
       setTriggerLabel(trigger.label);
     }
@@ -244,7 +244,9 @@ export function ChangeDataView({
                         {
                           defaultMessage:
                             "Switching data views removes the current {textBasedLanguage} query. Save this search to ensure you don't lose work.",
-                          values: { textBasedLanguage },
+                          values: {
+                            textBasedLanguage: getLanguageDisplayName(textBasedLanguage),
+                          },
                         }
                       )}
                     >

diff --git a/src/plugins/unified_search/public/dataview_picker/text_languages_transition_modal.tsx b/src/plugins/unified_search/public/dataview_picker/text_languages_transition_modal.tsx
@@ -8,7 +8,7 @@
 
 import React, { useState, useCallback } from 'react';
 import { i18n } from '@kbn/i18n';
-
+import { getLanguageDisplayName } from '@kbn/es-query';
 import {
   EuiModal,
   EuiModalBody,
@@ -39,7 +39,7 @@ export default function TextBasedLanguagesTransitionModal({
     setDismissModalChecked(e.target.checked);
   }, []);
 
-  const language = textBasedLanguage?.toUpperCase();
+  const language = getLanguageDisplayName(textBasedLanguage);
   return (
     <EuiModal onClose={() => setIsTextLangTransitionModalVisible(false)} style={{ width: 700 }}>
       <EuiModalHeader>

diff --git a/src/plugins/unified_search/public/query_string_input/query_bar_top_row.tsx b/src/plugins/unified_search/public/query_string_input/query_bar_top_row.tsx
@@ -90,7 +90,7 @@ const getWrapperWithTooltip = (
         position="top"
         content={i18n.translate('unifiedSearch.query.queryBar.textBasedNonTimestampWarning', {
           defaultMessage:
-            'Date range selection for {language} queries requires the presence of an @timestamp field in the dataset.',
+            'Date range selection for {language} queries requires an @timestamp field in the dataset.',
           values: { language: displayName },
         })}
       >