Review remarks

jepsar · Dec 11, 2023 · dc14b28 · dc14b28
1 parent 726eccc
commit dc14b28
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 6 deletions.
diff --git a/primefaces-showcase/src/main/webapp/ui/message/staticMessage.xhtml b/primefaces-showcase/src/main/webapp/ui/message/staticMessage.xhtml
@@ -14,6 +14,7 @@
     </ui:define>
 
     <ui:param name="documentationLink" value="/components/staticmessage"/>
+    <ui:param name="widgetLink" value="StaticMessage"/>
 
     <ui:define name="implementation">
         <p:growl id="growl"/>

diff --git a/primefaces/src/main/java/org/primefaces/component/staticmessage/StaticMessage.java b/primefaces/src/main/java/org/primefaces/component/staticmessage/StaticMessage.java
@@ -55,13 +55,13 @@ public Collection<String> getUnobstrusiveEventNames() {
     }
 
     @Override
-    public void queueEvent(final FacesEvent event) {
+    public void queueEvent(FacesEvent event) {
         FacesContext context = getFacesContext();
         Map<String, String> params = context.getExternalContext().getRequestParameterMap();
         String eventName = params.get(Constants.RequestParams.PARTIAL_BEHAVIOR_EVENT_PARAM);
 
         if (eventName != null && event instanceof AjaxBehaviorEvent) {
-            final AjaxBehaviorEvent ajaxBehaviorEvent = (AjaxBehaviorEvent) event;
+            AjaxBehaviorEvent ajaxBehaviorEvent = (AjaxBehaviorEvent) event;
 
             if ("close".equals(eventName)) {
                 customEvents.put(eventName, ajaxBehaviorEvent);

diff --git a/primefaces/src/main/java/org/primefaces/component/staticmessage/StaticMessageBase.java b/primefaces/src/main/java/org/primefaces/component/staticmessage/StaticMessageBase.java
@@ -63,7 +63,7 @@ public String getWidgetVar() {
         return (String) getStateHelper().eval(PropertyKeys.widgetVar, null);
     }
 
-    public void setWidgetVar(final String widgetVar) {
+    public void setWidgetVar(String widgetVar) {
         getStateHelper().put(PropertyKeys.widgetVar, widgetVar);
     }
 

diff --git a/primefaces/src/main/java/org/primefaces/component/staticmessage/StaticMessageRenderer.java b/primefaces/src/main/java/org/primefaces/component/staticmessage/StaticMessageRenderer.java
@@ -34,7 +34,7 @@
 public class StaticMessageRenderer extends UINotificationRenderer {
 
     @Override
-    public void decode(final FacesContext context, final UIComponent component) {
+    public void decode(FacesContext context, UIComponent component) {
         decodeBehaviors(context, component);
     }
 
@@ -126,7 +126,7 @@ protected void encodeCloseIcon(FacesContext context, StaticMessage staticMessage
     }
 
     protected void encodeScript(FacesContext context, StaticMessage staticMessage) throws IOException {
-        final WidgetBuilder wb = getWidgetBuilder(context);
+        WidgetBuilder wb = getWidgetBuilder(context);
         wb.init("StaticMessage", staticMessage);
 
         encodeClientBehaviors(context, staticMessage);

diff --git a/primefaces/src/main/resources/META-INF/resources/primefaces/staticmessage/staticmessage.js b/primefaces/src/main/resources/META-INF/resources/primefaces/staticmessage/staticmessage.js
@@ -30,7 +30,9 @@ PrimeFaces.widget.StaticMessage = PrimeFaces.widget.BaseWidget.extend({
             if ($this.hasBehavior('close')) {
                 $this.callBehavior('close');
             }
-        });
+        })
+            .attr('role', 'button')
+            .attr('aria-label', PrimeFaces.getAriaLabel('close'));
     }
 
 });