Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HI @jenskutilek, this PR includes the following minor fixes to solve some Fails reported, and some changes proposal:
Moderate
instead ofMedium
. Making it moreBLEED
related and to detach it from thewght
axis instance name to avoid confusing users.wght
axis. We'll need to discuss and approve this internally—but adding them for now to make the case.Close
instead ofNormal
(or Regular), making it more related to the otherSCAN
instance names and to detach it from thewdth
axis instance name to avoid confusing users.SCAN
axis were taken by translating the internal positions in the range (20:250) 1:1 to the final axis range (-100:100). However, given this is a custom axis, I think it would be possible to decide to what positions they are mapped. But again, this also would need to be discussed and approved internally before reaching a final decision.Please note that
Moderate
andClose
are only suggestions. You may choose to use different words of your preference. The crucial aspect is to avoid using words that may cause confusion with other axes, such as "Medium" or "Normal", and select more meaningful words that relate to the concept of each axis.You could download my
QA-home-2
branch to inspect the fonts before merging this so that all the above gets clearer :) Please let me know if you have any questions.