Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small production fixes #18

Merged
merged 13 commits into from
Sep 6, 2023
Merged

Conversation

vv-monsalve
Copy link
Contributor

HI @jenskutilek, this PR includes the following minor fixes to solve some Fails reported, and some changes proposal:

  • BLED axis location fixed, changing the previous 500 max value to 100, according to the final definitions done for this axis
  • Adding a localized family name for the "Medium" and "Strong" subfamilies.
    • I'm proposing Moderate instead of Medium. Making it more BLEED related and to detach it from the wght axis instance name to avoid confusing users.
  • I'm adding some fvar instances (the ones for the main family) for the font, given it doesn't have a wght axis. We'll need to discuss and approve this internally—but adding them for now to make the case.
    • I'm proposing Close instead of Normal (or Regular), making it more related to the other SCAN instance names and to detach it from the wdth axis instance name to avoid confusing users.
    • The proposed "output" values for the SCAN axis were taken by translating the internal positions in the range (20:250) 1:1 to the final axis range (-100:100). However, given this is a custom axis, I think it would be possible to decide to what positions they are mapped. But again, this also would need to be discussed and approved internally before reaching a final decision.
  • The current VF origin is the "Regular" master that matches the "Delicate" instance. If you would like any other intermediate position to be the Default, a master must be included.

Please note that Moderate and Close are only suggestions. You may choose to use different words of your preference. The crucial aspect is to avoid using words that may cause confusion with other axes, such as "Medium" or "Normal", and select more meaningful words that relate to the concept of each axis.

You could download my QA-home-2 branch to inspect the fonts before merging this so that all the above gets clearer :) Please let me know if you have any questions.

@jenskutilek jenskutilek merged commit f24f1d5 into jenskutilek:master Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants