Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nav+masthead): Edit navbar styling to handle dynamic window sizing #6

Closed
wants to merge 1 commit into from
Closed

fix(nav+masthead): Edit navbar styling to handle dynamic window sizing #6

wants to merge 1 commit into from

Conversation

jenny-s51
Copy link
Owner

@jenny-s51 jenny-s51 commented Jan 20, 2025 •
edited
Loading

Towards https://issues.redhat.com/browse/RHOAIENG-17619.

Edit navbar styling to handle dynamic window sizing.

Description

Adds media query to set proper margin on small viewports.

How Has This Been Tested?

  1. npm install and run Model Registry UI.

To run:

cd clients/ui/frontend && npm run start:dev   

cd clients/ui/bff && make run MOCK_K8S_CLIENT=true MOCK_MR_CLIENT=true
  1. Resize viewport to test updates.

Current:

MR-UI.mov

Target:

Kubeflow-Central-UI.mov

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

@jenny-s51 jenny-s51 marked this pull request as draft January 20, 2025 16:24
@jenny-s51
add media query to set proper margin on small viewports
3dda070 
Signed-off-by: Jenny <[email protected]>

remove left marign

fix masthead toggle alignment

fix comment

fix import order
jenny-s51
jenny-s51 commented Jan 22, 2025
View reviewed changes
Copy link
Owner Author

@jenny-s51 jenny-s51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged via kubeflow#721.

@jenny-s51 jenny-s51 closed this Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area/UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jenny-s51