Model Info: Theme "Versions" and "Details" Tabs #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jenny <[email protected]> fix tests Signed-off-by: Jenny <[email protected]> add fieldset to custom components fix spacing issue with helper text Signed-off-by: Jenny <[email protected]> remove comment Signed-off-by: Jenny <[email protected]> fixes for text area Signed-off-by: Jenny <[email protected]> format Signed-off-by: Jenny <[email protected]> add model description fix Signed-off-by: Jenny <[email protected]> create reusable fieldset component Signed-off-by: Jenny <[email protected]> move fieldset to components Signed-off-by: Jenny <[email protected]> add prop for className Signed-off-by: Jenny <[email protected]> lint Signed-off-by: Jenny <[email protected]> fix import warnings fix TS error with FormFieldset.tsx Signed-off-by: Jenny <[email protected]> fix import order errors
jenny-s51
force-pushed
the
themeModelInfoScreens
branch
2 times, most recently
from
269e414 to
90b231e
Compare
Signed-off-by: Jenny <[email protected]> apply theming to model info screens fix button color on hover add comment fix button color on hover Signed-off-by: Jenny <[email protected]> format update to absolute path
jenny-s51
force-pushed
the
themeModelInfoScreens
branch
from
c7e9be9 to
0ce7107
Compare
jenny-s51
commented
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Towards https://issues.redhat.com/browse/RHOAIENG-13191.
Merge criteria:
Dependent on changes in kubeflow#451 - will open for review onced merged/rebased.