-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restore java8 compatability - alternative #107
base: main
Are you sure you want to change the base?
Conversation
@@ -6,7 +6,7 @@ | |||
<parent> | |||
<groupId>org.jenkins-ci</groupId> | |||
<artifactId>jenkins</artifactId> | |||
<version>1.83</version> | |||
<version>1.85-20220804.113638-2</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
upstream has no incremental publishing - this was deployed locally and would need updating to a release when it is made (if accepted)
<version>1.85-20220804.113638-2</version> | |
<version>1.85</version> |
I do not see a strong reason to restore Java 8 compatibility. |
@kuisathaverat Could you confirm that you neither want to
I.e. you insist this plugin be distributed to folks on the current LTS line for which we claim Java 8 compatibility? (We don't have the infra set up to distinguish by Java dependency -- and adding it wouldn't be quick, Jenkins doesn't tell the update site like it tells us about the core version.) |
the plugins version is suspended from the update center so nobody will install it, the next version will bump the Jenkins Core to the next LTS with Java 11 only support, Are there any issue is not covered by theese measures? |
@kuisathaverat If there's not going to be a new release before you raise the core dependency to the next LTS baseline newer than 2.357, that's should also work out (suspending plugins for a while has come back to bite us in the past, but if we don't release the BOM or similar it should work out). |
jenkinsci/trilead-api-plugin#55 set the base line on 2.361 so no new releases with support for Java 8 |
@kuisathaverat would you please move forward with either the restoration of java8 in this project or jenkinsci/trilead-api-plugin#55? |
As I commented before #107 (comment) I will merge jenkinsci/trilead-api-plugin#55 next week. |
I think this PR can be closed |
See JENKINS-69229.
downstream of jenkinsci/pom#297 and an alternative to #106
Submitter checklist