Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable-cd and rebase #9

Merged
merged 1 commit into from
Dec 21, 2023
Merged

enable-cd and rebase #9

merged 1 commit into from
Dec 21, 2023

Conversation

bernardbdas
Copy link
Collaborator

@bernardbdas bernardbdas commented Dec 18, 2023

Testing done

Submitter checklist

@Simplify3x
Copy link
Collaborator

Hi @NotMyFault,
We did not rebase it in the earlier PR.
Can you review this PR and let us know if we are good to go for a rebase or not?

image
I hope this is what you mean by rebase.

@NotMyFault
Copy link
Member

You want to rebase the RPU PR as outlined, not the PR towards your plugin.

@Simplify3x
Copy link
Collaborator

We don't have that option available for RPU PR.

image

@NotMyFault
Copy link
Member

We don't have that option available for RPU PR.

image

Then do that by using the command line?

@Simplify3x
Copy link
Collaborator

Simplify3x commented Dec 18, 2023

image

We have already created a fork and raised a PR.
You need to accept the incoming changes to RPU from the PR and merge.

@Simplify3x
Copy link
Collaborator

Can we please close this soon?
@NotMyFault

Comment on lines +11 to +14
- package-ecosystem: "maven"
directory: "/"
schedule:
interval: "weekly"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You already have this on line 3 to 6.
You can change there the interval if you want the Maven dependencies to be checked more frequently than every month.

@Simplify3x Simplify3x merged commit d50a3db into jenkinsci:master Dec 21, 2023
16 checks passed
@alecharp
Copy link
Member

As long as jenkins-infra/repository-permissions-updater#3685 is not merged, you shouldn't have merged this as you still don't have the required credentials in this repository for the CD workflow to have the permissions to push any binary to the Maven Repository Manager of the community.

@Simplify3x
Copy link
Collaborator

Can you suggest an actionable plan?
We need this plugin updated as soon as possible.

@NotMyFault
Copy link
Member

Can you suggest an actionable plan?

We need this plugin updated as soon as possible.

I'd recommend being patient instead of bugging us every day, people are on Christmas and new years leave. Things will be slower than usual.

Thanks for understanding.

@Simplify3x
Copy link
Collaborator

Hi @NotMyFault
Can we get an update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants