Improve documentation for exact versioning #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reflect the correct behavior of application version in case of exact versioning (e.g. 1.0.1 instead of 1.0) in the documentation Reference: jenkinsci#34
Add test for calculated app version based on build number Reference: jenkinsci#34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes contain updates in the README and help text for app version to better describe the behavior of exact versioning, e.g. MAJOR.MINOR.PATCH (e.g. 1.0.1). This is working but it is not covered in the documentation. The docs only mention versioning based on MAJOR.MINOR and BUILD_NUMBER.
Moreover, I have added a test case to cover the calculation of app version based on MAJOR.MINOR and BUILD_NUMBER.
This PR closes #34.