[FIXED JENKINS-24576] Feature to mark build unstable when no files uploaded #37
Conversation
… uploaded for a specific file pattern.
|
plugins » s3-plugin #50 SUCCESS |
|
👍 |
|
@christ66 If you can bring this up to date with the latest code I will look at merging |
Conflicts: src/main/resources/hudson/plugins/s3/S3BucketPublisher/config.jelly
|
@dmbeer Sorry about the delay. I thought I had pushed these changes but I forgot. |
|
@dmbeer Any updates on this getting merged in? We really need to know when files are not uploaded successfully in our builds. |
|
@reviewbybees |
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
| @@ -41,6 +41,11 @@ | |||
| public boolean noUploadOnFailure; | |||
|
|
|||
| /** | |||
| * Fail the build if no files were uploaded. | |||
| */ | |||
| public boolean failNoFilesToUpload; | |||
There was a problem hiding this comment.
Where is the code, which initializes this variable?
There was a problem hiding this comment.
I'm not a big fan of public non-final fields due to all kinds of concurrency issues and potential misusages, but it does not increase the technical debt in this class.
There was a problem hiding this comment.
I think I messed up the merge commit. It looks like that reverted the code change in the config.jelly file.
If a build failed to upload any files, this adds the feature to mark a build then as unstable.