Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow assume role #129

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Conversation

lewgordon
Copy link

@lewgordon lewgordon commented Apr 15, 2020

May duplicate #116 . Many times we'll need to assume a role as specifying a user's credentials doesn't work in most of our cases since we'll require a security token.

@anthonygreen
Copy link

This is a feature requirement for our setup where Jenkins is running on a EC2 instance and the plugin needs to be able to upload to a bucket in another account via AWS's assume role capability.
We previously used #116 but the master branch has since diverged considerably from that point.

@anthonygreen
Copy link

#116 also adds the capability to assign a canned ACL for uploaded objects, useful when using S3 to host static web assets.

@anthonygreen
Copy link

I've build the patched fork and installed that version of the plugin on a test Jenkins instance.
two things:

  1. Use IAM role check box doesn't appear to be saving state.
  2. There needs to be instructions on how to set up, as I haven't been able to get it to work correctly

@lewgordon
Copy link
Author

@anthonygreen Yeah, I definitely think I need more docs on this. Currently we use it internally on our Jenkins so I haven't given much thought to it. If you want to just have the profile assume the role, you need to specify the role under "Assume IAM Role" and NOT check the "Use IAM Role" box. When clicking away you should see some validation if the master is able to assume the IAM role. If that doesn't work there's probably some bug somewhere in my fork that I need to fix. :)

@anthonygreen
Copy link

anthonygreen commented May 15, 2020

Seems the bug with the IAM role was accidentally introduced with ee92830 and requires #128 to fix

@anthonygreen
Copy link

Is there any prospect of these changes being updated so they can be easily merged into a fork of the current head of jenkinsci:master ?

@rsandell
Copy link
Member

Sorry, I didn't check for existing open PRs when I did #138 I believe this could be made less complex when applied on top of that.

@jglick
Copy link
Member

jglick commented Oct 15, 2021

Offhand I would expect this sort of thing to be handled by the aws-credentials plugin instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants